All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Mc Guire <der.herr@hofr.at>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
	Josh Triplett <josh@joshtriplett.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] rcuperf: make timeout HZ independent
Date: Mon, 22 Aug 2016 12:19:49 +0000	[thread overview]
Message-ID: <20160822121949.GA26136@osadl.at> (raw)
In-Reply-To: <20160822114943.GY3482@linux.vnet.ibm.com>

On Mon, Aug 22, 2016 at 04:49:43AM -0700, Paul E. McKenney wrote:
> On Mon, Aug 22, 2016 at 01:21:05PM +0200, Nicholas Mc Guire wrote:
> > Make the probability of ftrace dump not interfering with other writers 
> > grace period, HZ independent.
> > 
> > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> 
> What we would -really- like is to vary the time based on the clock rate
> of the CPUs (could use bogomips, I suppose) and the memory latency of
> the system, so that systems with smaller memory latency and faster CPUs
> would use shorter timeouts.  However, slower CPUs tend to use smaller
> HZ values, so varying based on HZ is not entirely insane.
> 
> But what would you suggest?

so what you want is a rough estimate of a "fixed instruction quantum"
while bogomips/cpu_khz would ignore memory latency it might still be
better than a fixed time then - something like 
  schedule_timeout(msecs_to_jiffies(10000/cpu_khz)); ?

> 
> Good question on schedule_timeout_interruptible()...  I usually do that
> if there is some reason to be sensitive to an early wakeup, for example,
> to allow shutdown to proceed quickly, but that doesn't make much sense
> here, given that ftrace_dump() is likely to take a very long time.
>
ok - just though that I was overlooking something - thanks for the 
clarification.

thx!
hofrat 

      reply	other threads:[~2016-08-22 12:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-22 11:21 [PATCH RFC] rcuperf: make timeout HZ independent Nicholas Mc Guire
2016-08-22 11:49 ` Paul E. McKenney
2016-08-22 12:19   ` Nicholas Mc Guire [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160822121949.GA26136@osadl.at \
    --to=der.herr@hofr.at \
    --cc=hofrat@osadl.org \
    --cc=jiangshanlai@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.