All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] configs/pc_x86_64_efi_defconfig: enable kernel EFI support
Date: Mon, 22 Aug 2016 16:37:41 +0200	[thread overview]
Message-ID: <20160822163741.021a7577@free-electrons.com> (raw)
In-Reply-To: <20160822015216.425-2-nunes.erico@gmail.com>

Hello,

Added Gustavo in Cc, since he is the original author of this defconfig.

On Mon, 22 Aug 2016 03:52:16 +0200, Erico Nunes wrote:
> The pc_x86_64_efi reference defconfig is targeted towards an EFI
> environment but the kernel which comes with it does not enable EFI
> support by default.
> 
> Booting this defconfig without kernel EFI support on a qemu virtual
> machine with EFI firmware resulted in no output to tty1 or ttyS0.
> Enabling EFI support in the kernel fixed this and seems saner for an EFI
> reference Buildroot defconfig.
> 
> CONFIG_EFI was enabled in a separate kernel config fragment so that it
> doesn't affect pc_x86_64_bios_defconfig needlessly.
> 
> This was tested with qemu 2.6.0 running with kvm enabled and firmware
> EFI v2.60 by EDK II.
> 
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> ---
>  board/pc/linux-efi.config       | 1 +
>  configs/pc_x86_64_efi_defconfig | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
>  create mode 100644 board/pc/linux-efi.config

Is a separate linux configuration fragment really needed? Why not just
enable CONFIG_EFI in the linux-extras.config?

Yes, it's technically not needed for a BIOS-based configuration, but
the added size is probably not very significant, and I'm not sure it's
worth having a separate linux config fragment for that.

Gustavo?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-08-22 14:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-22  1:52 [Buildroot] [PATCH 1/2] board/pc/readme.txt: fix output image name Erico Nunes
2016-08-22  1:52 ` [Buildroot] [PATCH 2/2] configs/pc_x86_64_efi_defconfig: enable kernel EFI support Erico Nunes
2016-08-22 14:37   ` Thomas Petazzoni [this message]
2016-08-22 14:40     ` Gustavo Zacarias
2016-08-22 14:44       ` Thomas Petazzoni
2016-08-22 14:52         ` Erico Nunes
2016-08-22 14:36 ` [Buildroot] [PATCH 1/2] board/pc/readme.txt: fix output image name Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160822163741.021a7577@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.