From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@kernel.org (Mark Brown) Date: Mon, 22 Aug 2016 17:52:59 +0100 Subject: [PATCH 4/9] regulator: axp20x: support AXP806 variant In-Reply-To: <20160821021125.1521-5-wens@csie.org> References: <20160821021125.1521-1-wens@csie.org> <20160821021125.1521-5-wens@csie.org> Message-ID: <20160822165259.GS22076@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Aug 21, 2016 at 10:11:20AM +0800, Chen-Yu Tsai wrote: > + if (id == AXP806_DCDCB) { > + return (((reg & GENMASK(7, 6)) == BIT(6)) || > + ((reg & GENMASK(7, 6)) == BIT(7))); > + } else if (id == AXP806_DCDCC) { > + return ((reg & GENMASK(7, 6)) == BIT(7)); > + } else if (id == AXP806_DCDCE) { > + return !!(reg & BIT(5)); > + } This looks like you're trying to write a switch statement, please do that. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 4/9] regulator: axp20x: support AXP806 variant Date: Mon, 22 Aug 2016 17:52:59 +0100 Message-ID: <20160822165259.GS22076@sirena.org.uk> References: <20160821021125.1521-1-wens@csie.org> <20160821021125.1521-5-wens@csie.org> Reply-To: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="o/5eNASeIIpuMggS" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20160821021125.1521-5-wens-jdAy2FN1RRM@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Lee Jones , Rob Herring , Mark Rutland , Liam Girdwood , Maxime Ripard , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --o/5eNASeIIpuMggS Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Sun, Aug 21, 2016 at 10:11:20AM +0800, Chen-Yu Tsai wrote: > + if (id == AXP806_DCDCB) { > + return (((reg & GENMASK(7, 6)) == BIT(6)) || > + ((reg & GENMASK(7, 6)) == BIT(7))); > + } else if (id == AXP806_DCDCC) { > + return ((reg & GENMASK(7, 6)) == BIT(7)); > + } else if (id == AXP806_DCDCE) { > + return !!(reg & BIT(5)); > + } This looks like you're trying to write a switch statement, please do that. --o/5eNASeIIpuMggS-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756030AbcHVQxU (ORCPT ); Mon, 22 Aug 2016 12:53:20 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:35190 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752364AbcHVQxS (ORCPT ); Mon, 22 Aug 2016 12:53:18 -0400 Date: Mon, 22 Aug 2016 17:52:59 +0100 From: Mark Brown To: Chen-Yu Tsai Cc: Lee Jones , Rob Herring , Mark Rutland , Liam Girdwood , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Message-ID: <20160822165259.GS22076@sirena.org.uk> References: <20160821021125.1521-1-wens@csie.org> <20160821021125.1521-5-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="o/5eNASeIIpuMggS" Content-Disposition: inline In-Reply-To: <20160821021125.1521-5-wens@csie.org> X-Cookie: Satire is what closes in New Haven. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 4/9] regulator: axp20x: support AXP806 variant X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --o/5eNASeIIpuMggS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Aug 21, 2016 at 10:11:20AM +0800, Chen-Yu Tsai wrote: > + if (id == AXP806_DCDCB) { > + return (((reg & GENMASK(7, 6)) == BIT(6)) || > + ((reg & GENMASK(7, 6)) == BIT(7))); > + } else if (id == AXP806_DCDCC) { > + return ((reg & GENMASK(7, 6)) == BIT(7)); > + } else if (id == AXP806_DCDCE) { > + return !!(reg & BIT(5)); > + } This looks like you're trying to write a switch statement, please do that. --o/5eNASeIIpuMggS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXuy3qAAoJECTWi3JdVIfQNk0H/1Gx2csm6YBGadyDxZtwhvHj FOKf5b5z4Dk1+sFMznUNZ8HsK1G0pgyDhdnNp+m14y0GCt6VUuSGmoYZCoCxVXKI 7c66lcTMXcBTIrLeFBzb4rUdwg4hw4Xpt0Cxgeti4fMR31JfeHT1kpD8zo6vNhdk w/29wVUZHE5pU0hn8n4V1MBW5gUWtjyaX/+8Cu9PMqojEjOyzDn7pmeZef8MBs35 RTnmMgwksHeW/zIoRvIfXaZ6voLMUSQxvl3n39G0G3HSFAX0MuT/q9hFzcwP2uxr Se4dK63uH1/V6XZTtHiUcmdRK2Tzd82yNIbL23y9DU74cPK0mm3oWgwDTJu3lDU= =RcA4 -----END PGP SIGNATURE----- --o/5eNASeIIpuMggS--