From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-input@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
Rakesh Iyer <riyer@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-tegra@vger.kernel.org, Alexandre Courbot <gnurou@gmail.com>
Subject: Re: [PATCH] Input: tegra-kbc: fix inverted reset logic
Date: Mon, 22 Aug 2016 14:20:06 -0700 [thread overview]
Message-ID: <20160822212006.GF12277@dtor-ws> (raw)
In-Reply-To: <1471316363-19378-1-git-send-email-yamada.masahiro@socionext.com>
On Tue, Aug 16, 2016 at 11:59:23AM +0900, Masahiro Yamada wrote:
> Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
> accidentally converted _deassert to _assert, so there is no code
> to wake up this hardware.
>
> Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied, thank you.
> ---
>
> drivers/input/keyboard/tegra-kbc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
> index 7d61439..0c07e10 100644
> --- a/drivers/input/keyboard/tegra-kbc.c
> +++ b/drivers/input/keyboard/tegra-kbc.c
> @@ -376,7 +376,7 @@ static int tegra_kbc_start(struct tegra_kbc *kbc)
> /* Reset the KBC controller to clear all previous status.*/
> reset_control_assert(kbc->rst);
> udelay(100);
> - reset_control_assert(kbc->rst);
> + reset_control_deassert(kbc->rst);
> udelay(100);
>
> tegra_kbc_config_pins(kbc);
> --
> 1.9.1
>
--
Dmitry
prev parent reply other threads:[~2016-08-22 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 2:59 [PATCH] Input: tegra-kbc: fix inverted reset logic Masahiro Yamada
2016-08-16 2:59 ` Masahiro Yamada
[not found] ` <1471316363-19378-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2016-08-16 10:26 ` Thierry Reding
2016-08-16 10:26 ` Thierry Reding
2016-08-16 11:16 ` Laxman Dewangan
2016-08-16 11:16 ` Laxman Dewangan
2016-08-22 21:20 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822212006.GF12277@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=gnurou@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=riyer@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.