From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Markus Heiser <markus.heiser@darmarit.de>,
Jani Nikula <jani.nikula@intel.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] docs-rst: kernel-doc: better output struct members
Date: Mon, 22 Aug 2016 21:40:55 -0300 [thread overview]
Message-ID: <20160822214055.7c56f06d@vento.lan> (raw)
In-Reply-To: <20160822153421.1e334ab0@lwn.net>
Em Mon, 22 Aug 2016 15:34:21 -0600
Jonathan Corbet <corbet@lwn.net> escreveu:
> On Sun, 21 Aug 2016 09:11:57 -0300
> Mauro Carvalho Chehab <mchehab@s-opensource.com> wrote:
>
> > So, change kernel-doc, for it to produce the output on a different way:
> >
> > **Members**
> >
> > ``prios[4]``
> > - **type**: ``atomic_t``
> >
> > array with elements to store the array priorities
> >
> > With such change, the name of the member will be the first visible
> > thing, and will be in bold style. The type will still be there, inside
> > a list.
>
> OK, I'll confess to not being 100% convinced on this one. I certainly
> sympathize with the problem that drives this change, but I think the
> result is a bit on the noisy and visually distracting side.
>
> I wonder if we might be better off to just leave the "type:" bulleted
> line out entirely? The type information already appears in the structure
> listing directly above, so it's arguably redundant here. If formatting
> the type is getting in the way here, perhaps the right answer is just
> "don't do that"?
I almost stripped the type on the first version of this patch, as I had
the same doubt as you ;)
I ended keeping it just because I didn't have a strong argument to
strip it.
There is another reason too... just stripping it will produce a
little difference at the output:
With HTML, the output is:
*struct v4l2_subdev_tuner_ops*
Callbacks used when v4l device was opened in radio mode.
...
*Members*
*s_radio*
callback for VIDIOC_S_RADIO ioctl handler code.
...
On LaTeX/PDF, is displayed as:
*struct v4l2_subdev_tuner_ops*
Callbacks used when v4l device was opened in radio mode.
...
*Members*
*s_radio* callback for VIDIOC_S_RADIO ioctl handler code.
Anyway, I'm OK on just stripping the type. I'm sending a second version
of it.
Thanks!
Mauro
next prev parent reply other threads:[~2016-08-23 0:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-21 12:11 [PATCH] docs-rst: kernel-doc: better output struct members Mauro Carvalho Chehab
2016-08-22 8:56 ` RFC? " Markus Heiser
2016-08-22 10:06 ` Mauro Carvalho Chehab
2016-08-22 11:16 ` Jani Nikula
2016-08-22 11:40 ` Markus Heiser
2016-08-22 11:52 ` Jani Nikula
2016-08-22 12:15 ` Mauro Carvalho Chehab
2016-08-22 12:23 ` Markus Heiser
2016-08-22 12:17 ` Markus Heiser
2016-08-22 11:42 ` Markus Heiser
2016-08-22 21:34 ` Jonathan Corbet
2016-08-23 0:40 ` Mauro Carvalho Chehab [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-08-23 0:41 Mauro Carvalho Chehab
2016-08-23 1:04 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822214055.7c56f06d@vento.lan \
--to=mchehab@s-opensource.com \
--cc=corbet@lwn.net \
--cc=jani.nikula@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=markus.heiser@darmarit.de \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.