All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: netdev@vger.kernel.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2 0/4] improve initialization of genl handle
Date: Tue, 23 Aug 2016 11:18:01 +0200	[thread overview]
Message-ID: <20160823091801.GG8820@orbyte.nwl.cc> (raw)
In-Reply-To: <cover.1471356460.git.sd@queasysnail.net>

On Tue, Aug 16, 2016 at 04:26:54PM +0200, Sabrina Dubroca wrote:
> This patchset fixes several issues for users of genetlink:
> 
>  - Duplicated code for initialization of a genl handle.
>    All users of genl must open a socket and resolve the family, and
>    use the same code to do that.
>    Solution: add a library function.
> 
>  - genl family resolution fails when the module that handles this
>    family is not loaded yet.
>    This means that if we try to initialize the genl handle early in
>    handling the command, we cannot display usage, because we fail hard
>    when trying to resolve the genl family.
>    Solution: move the genl handle initialization after handling the
>    `ip * help` case.
> 
> Sabrina Dubroca (4):
>   libgenl: introduce genl_init_handle
>   macsec: show usage even if the module is not available
>   fou: show usage even if the module is not available
>   ila: show usage even if the module is not available
> 
>  include/libgenl.h |  2 ++
>  ip/ipfou.c        | 20 ++++++--------------
>  ip/ipila.c        | 19 ++++++-------------
>  ip/ipl2tp.c       | 12 ++----------
>  ip/ipmacsec.c     | 20 +++-----------------
>  ip/tcp_metrics.c  | 14 +++-----------
>  lib/libgenl.c     | 17 +++++++++++++++++
>  7 files changed, 39 insertions(+), 65 deletions(-)

Series:
Acked-by: Phil Sutter <phil@nwl.cc>

      parent reply	other threads:[~2016-08-23  9:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-16 14:26 [PATCH iproute2 0/4] improve initialization of genl handle Sabrina Dubroca
2016-08-16 14:26 ` [PATCH iproute2 1/4] libgenl: introduce genl_init_handle Sabrina Dubroca
2016-08-16 14:26 ` [PATCH iproute2 2/4] macsec: show usage even if the module is not available Sabrina Dubroca
2016-08-16 14:26 ` [PATCH iproute2 3/4] fou: " Sabrina Dubroca
2016-08-16 14:26 ` [PATCH iproute2 4/4] ila: " Sabrina Dubroca
2016-08-23  9:18 ` Phil Sutter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160823091801.GG8820@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=netdev@vger.kernel.org \
    --cc=sd@queasysnail.net \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.