All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbeldan@baylibre.com (Karl Beldan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching
Date: Tue, 23 Aug 2016 09:52:37 +0000	[thread overview]
Message-ID: <20160823095237.GA8276@gobelin> (raw)
In-Reply-To: <2ef9651f-9a1e-3fb6-cc81-b1b714c9e043@ti.com>

On Tue, Aug 23, 2016 at 02:43:36PM +0530, Sekhar Nori wrote:
> On Friday 19 August 2016 10:17 PM, Karl Beldan wrote:
> > The davinci boards don't have their clocks in DT yet and getting a clock
> > with a null con_id will fail, unless registering them as clk_lookups.
> 
> This statement is true, but I am not sure why you limit it to those
> clocks with null con_id. On DaVinci, all clocks need to be registered
> via a clk_lookup entry. Else clk_get() will fail.
> 
> So can I just edit this to:
> 
> "
> The davinci boards don't have their clocks in DT yet and getting a clock
> will fail, unless registering them as clk_lookups.
> "
> 
> while applying?
> 

Sure, as well as a 'reworded commit message' tag.

Thanks, 
Karl

> > This registers the aemif clock for the ti-aemif memory driver.
> > 
> > The current aemif lookup entry resolving to the same clock:
> >     'CLK(NULL,               "aemif",        &aemif_clk)'
> > is currently used by davinci_nand and remains for non-DT and backward
> > compatibility.
> > 
> > Currently the davinci boards only configure the AEMIF in case of non-DT
> > boot, via some code in mach-davinci.
> > This change will allow DT-based davinci platforms to do the same, via
> > the ti-aemif memory driver code.
> > 
> > Signed-off-by: Karl Beldan <kbeldan@baylibre.com>
> > ---
> >  This patch was originally patch 1/4 of the series
> >  "Add DT support for NAND to LCDK via ti-aemif" from which two other
> >  patches have already applied in Sekhar's tree.
> >  Sekhar, please note that commit 31e3a881 ("ARM: dts: da850,da850-evm:
> >  Add an aemif node and use it for the NAND") of your tree depends on
> >  this change.
> 
> yes, noted. While sending the pull request to ARM-SoC, I send the SoC
> changes first.
> 
> Thanks,
> Sekhar

  reply	other threads:[~2016-08-23  9:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-19 16:47 [PATCH] ARM: davinci_all_defconfig: Enable some UBI modules Karl Beldan
2016-08-19 16:47 ` [PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching Karl Beldan
2016-08-23  9:13   ` Sekhar Nori
2016-08-23  9:52     ` Karl Beldan [this message]
2016-08-23 11:06       ` Sekhar Nori
2016-08-19 16:58 ` [PATCH] ARM: davinci_all_defconfig: Enable some UBI modules Karl Beldan
2016-08-23 10:53 ` Sekhar Nori
  -- strict thread matches above, loose matches on Subject: below --
2016-08-19 16:48 Karl Beldan
2016-08-19 16:48 ` [PATCH v2] ARM: davinci: da8xx-dt: Add ti-aemif lookup for clock matching Karl Beldan
2016-08-19 16:55   ` Karl Beldan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160823095237.GA8276@gobelin \
    --to=kbeldan@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.