From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757885AbcHWNHw (ORCPT ); Tue, 23 Aug 2016 09:07:52 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39434 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757185AbcHWNHv (ORCPT ); Tue, 23 Aug 2016 09:07:51 -0400 Date: Tue, 23 Aug 2016 09:07:57 -0400 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: devel@driverdev.osuosl.org, Fengguang Wu , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: i4l: icn: use memdup_user Message-ID: <20160823130757.GB20271@kroah.com> References: <1471948054-15651-1-git-send-email-sudipm.mukherjee@gmail.com> <20160823105030.GA11124@kroah.com> <20160823105812.GB9708@sudip-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160823105812.GB9708@sudip-laptop> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 23, 2016 at 04:28:12PM +0530, Sudip Mukherjee wrote: > On Tue, Aug 23, 2016 at 06:50:30AM -0400, Greg Kroah-Hartman wrote: > > On Tue, Aug 23, 2016 at 03:57:34PM +0530, Sudip Mukherjee wrote: > > > Its better to use memdup_user which does the same thing which this > > > code has implemented. > > > > > > Suggested-by: Fengguang Wu > > > Signed-off-by: Sudip Mukherjee > > > --- > > > drivers/staging/i4l/icn/icn.c | 16 +++++----------- > > > 1 file changed, 5 insertions(+), 11 deletions(-) > > > > > > diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c > > > index b2f4055..5312675 100644 > > > --- a/drivers/staging/i4l/icn/icn.c > > > +++ b/drivers/staging/i4l/icn/icn.c > > > @@ -804,21 +804,16 @@ static int > > > icn_loadboot(u_char __user *buffer, icn_card *card) > > > { > > > int ret; > > > - u_char *codebuf; > > > + void *codebuf; > > > > why did you change the type here? > > type was changed as codebuf is only used with memdup_user() and > memcpy_toio() and both of them takes void. I should have mentioned > that in the commit message. Sending v2 with this change and after > removing the warning. No, please leave the type alone, you are changing it for no good reason (and in fact, it might be a bad change if anything else were to use that pointer...) greg k-h