From: Wolfram Sang <wsa@the-dreams.de>
To: Jan Glauber <jglauber@cavium.com>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
David Daney <ddaney@caviumnetworks.com>,
Steven.Hill@caviumnetworks.com
Subject: Re: [PATCH v10 3/8] i2c: thunderx: Add i2c driver for ThunderX SOC
Date: Tue, 23 Aug 2016 22:39:41 +0200 [thread overview]
Message-ID: <20160823203941.GC20872@katana> (raw)
In-Reply-To: <20160823203628.GB20872@katana>
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
On Tue, Aug 23, 2016 at 10:36:29PM +0200, Wolfram Sang wrote:
>
> > i2c-octeon-objs := i2c-cavium.o i2c-octeon-core.o
> > obj-$(CONFIG_I2C_OCTEON) += i2c-octeon.o
> > +i2c-thunderx-objs := i2c-cavium.o i2c-thunderx-core.o
> > +obj-$(CONFIG_I2C_THUNDERX) += i2c-thunderx.o
>
> Shouldn't that rather be "i2c-cavium-core.o",
Thinking of it again, it should probably even be "i2c-octeon-core.o" to
avoid confusion because all the functions start with octeon_*
> "i2c-octeon-platdrv.o", and "i2c-thunderx-pcidrv.o" for the -objs?
Those names still make sense :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-23 20:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 13:51 [PATCH v10 0/8] i2c-octeon and i2c-thunderx driver Jan Glauber
2016-06-15 13:51 ` [PATCH v10 1/8] i2c: octeon: Rename driver to prepare for split Jan Glauber
2016-06-15 13:51 ` [PATCH v10 2/8] i2c: octeon: Split the driver into two parts Jan Glauber
2016-06-15 13:51 ` [PATCH v10 3/8] i2c: thunderx: Add i2c driver for ThunderX SOC Jan Glauber
2016-08-23 20:36 ` Wolfram Sang
2016-08-23 20:39 ` Wolfram Sang [this message]
2016-08-23 21:09 ` Jan Glauber
2016-08-23 21:09 ` Jan Glauber
2016-08-23 21:22 ` Jan Glauber
2016-08-23 21:22 ` Jan Glauber
2016-06-15 13:51 ` [PATCH v10 4/8] i2c: thunderx: Add SMBUS alert support Jan Glauber
2016-08-23 20:57 ` Wolfram Sang
2016-08-23 21:28 ` Jan Glauber
2016-08-23 21:28 ` Jan Glauber
2016-08-23 21:39 ` Wolfram Sang
2016-08-23 21:52 ` Jan Glauber
2016-08-23 21:52 ` Jan Glauber
2016-06-15 13:51 ` [PATCH v10 5/8] i2c: octeon,thunderx: Move register offsets to struct Jan Glauber
2016-06-15 13:51 ` [PATCH v10 6/8] i2c: octeon: Sort include files alphabetically Jan Glauber
2016-06-15 13:51 ` [PATCH v10 7/8] i2c: cavium: Use booleon values for booleon variables Jan Glauber
2016-06-15 13:51 ` [PATCH v10 8/8] i2c: octeon: thunderx: Add MAINTAINERS entry Jan Glauber
2016-08-23 21:00 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823203941.GC20872@katana \
--to=wsa@the-dreams.de \
--cc=Steven.Hill@caviumnetworks.com \
--cc=ddaney@caviumnetworks.com \
--cc=jglauber@cavium.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.