Re: [Qemu-devel] [PULL 2/2] e1000e: remove internal interrupt flag

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Aug 23, 2016 at 11:12:21PM +0200, Markus Armbruster wrote:
> Amit Shah <amit.shah@redhat.com> writes:
> 
> > On (Mon) 22 Aug 2016 [16:09:27], Jason Wang wrote:
> >> From: Cao jin <caoj.fnst@cn.fujitsu.com>
> >> 
> >> Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, E1000E_USE_MSIX
> >> is not necessary too, remove it now. And interrupt flag field intr_state also
> >> can be removed now.
> >> 
> >> CC: Dmitry Fleytman <dmitry@daynix.com>
> >> CC: Jason Wang <jasowang@redhat.com>
> >> CC: Markus Armbruster <armbru@redhat.com>
> >> CC: Marcel Apfelbaum <marcel@redhat.com>
> >> CC: Michael S. Tsirkin <mst@redhat.com>
> >> CC: Paolo Bonzini <pbonzini@redhat.com>
> >> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> >> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> >> Acked-by: Dmitry Fleytman <dmitry@daynix.com>
> >> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> >> Signed-off-by: Jason Wang <jasowang@redhat.com>
> >> ---
> >>  hw/net/e1000e.c | 8 +-------
> >>  1 file changed, 1 insertion(+), 7 deletions(-)
> >
> >
> >> @@ -601,7 +596,6 @@ static const VMStateDescription e1000e_vmstate = {
> >>          VMSTATE_MSIX(parent_obj, E1000EState),
> >>  
> >>          VMSTATE_UINT32(ioaddr, E1000EState),
> >> -        VMSTATE_UINT32(intr_state, E1000EState),
> >>          VMSTATE_UINT32(core.rxbuf_min_shift, E1000EState),
> >>          VMSTATE_UINT8(core.rx_desc_len, E1000EState),
> >>          VMSTATE_UINT32_ARRAY(core.rxbuf_sizes, E1000EState,
> >
> > This breaks migration - please mark that field 'unused'.
> 
> Does it matter?  The device hasn't been in any released version of
> QEMU...

Ah so that's why we are merging this patch before 2.7 - to keep
migration format clean.
I withdraw my objection.

-- 
MST