From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Roman Kagan <rkagan@virtuozzo.com>,
qemu-devel@nongnu.org, "Denis V. Lunev" <den@openvz.org>,
Ladi Prosek <lprosek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/6] virtio: assert on ->inuse underflow
Date: Wed, 24 Aug 2016 05:42:44 +0300 [thread overview]
Message-ID: <20160824054226-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20160823210332.GA6227@stefanha-x1.localdomain>
On Tue, Aug 23, 2016 at 05:03:32PM -0400, Stefan Hajnoczi wrote:
> On Fri, Aug 19, 2016 at 04:39:20PM +0300, Roman Kagan wrote:
> > Make sure that ->inuse counter on virtqueue never goes negative.
> >
> > This complements commit afd9096eb1882f23929f5b5c177898ed231bac66,
> > "virtio: error out if guest exceeds virtqueue size", which, due to
> > signed ->inuse comparison against unsigned ->vring.num, manifested a bug
> > in virtio-balloon where virtqueue_push() was called before the matching
> > virtqueu_pop(). [That problem will be addressed in followup patches].
> >
> > Signed-off-by: Roman Kagan <rkagan@virtuozzo.com>
> > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > Cc: Ladi Prosek <lprosek@redhat.com>
> > Cc: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > hw/virtio/virtio.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
I'm not merging any asserts before 2.7. Please resubmit when 2.7
is out.
next prev parent reply other threads:[~2016-08-24 2:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 13:39 [Qemu-devel] [PATCH v2 0/6] virtio-balloon: assorted fixes Roman Kagan
2016-08-19 13:39 ` [Qemu-devel] [PATCH v2 1/6] virtio: assert on ->inuse underflow Roman Kagan
2016-08-23 21:03 ` Stefan Hajnoczi
2016-08-24 2:42 ` Michael S. Tsirkin [this message]
2016-08-19 13:39 ` [Qemu-devel] [PATCH v2 2/6] virtio-balloon: make stats virtqueue length 1 Roman Kagan
2016-08-22 1:57 ` Michael S. Tsirkin
2016-08-19 13:39 ` [Qemu-devel] [PATCH v2 3/6] virtio-balloon: don't restart stats timer in callback Roman Kagan
2016-08-19 13:39 ` [Qemu-devel] [PATCH v2 4/6] virtio-balloon: keep collecting stats on save/restore Roman Kagan
2016-09-01 8:35 ` Ladi Prosek
2016-09-01 14:17 ` Roman Kagan
2016-09-01 15:43 ` Ladi Prosek
2016-09-01 16:18 ` Michael S. Tsirkin
2016-09-01 18:03 ` Roman Kagan
2016-08-19 13:39 ` [Qemu-devel] [PATCH v2 5/6] virtio-balloon: drop ->stats_vq_offset Roman Kagan
2016-08-19 13:39 ` [Qemu-devel] [PATCH v2 6/6] virtio-ballon: drop reset handler Roman Kagan
2016-08-19 13:43 ` Roman Kagan
2016-08-19 13:39 ` [Qemu-devel] [PATCH v2 6/6] virtio-balloon: " Roman Kagan
2016-08-19 14:48 ` [Qemu-devel] [PATCH v2 0/6] virtio-balloon: assorted fixes Roman Kagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160824054226-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=den@openvz.org \
--cc=lprosek@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.