From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Subject: Re: [PATCH v2] drm: Add reference counting to drm_atomic_state Date: Wed, 24 Aug 2016 10:17:49 +0100 Message-ID: <20160824091749.GJ16673@imgtec.com> References: <20160823214331.26332-1-chris@chris-wilson.co.uk> <20160824061015.30907-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160824061015.30907-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBdWcgMjQsIDIwMTYgYXQgMDc6MTA6MTVBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IGRybV9hdG9taWNfc3RhdGUgaGFzIGEgY29tcGxpY2F0ZWQgc2luZ2xlIG93bmVyIG1v ZGVsIHRoYXQgdHJhY2tzIHRoZQo+IHNpbmdsZSByZWZlcmVuY2UgZnJvbSBhbGxvY2F0aW9uIHRo cm91Z2ggdG8gZGVzdHJ1Y3Rpb24gb24gYW5vdGhlcgo+IHRocmVhZCAtIG9yIHBlcmhhcHMgb24g YSBsb2NhbCBlcnJvciBwYXRoLiBXZSBjYW4gc2ltcGxpZnkgdGhpcyB0cmFja2luZwo+IGJ5IHVz aW5nIHJlZmVyZW5jZSBjb3VudGluZyAoYXQgYSBjb3N0IG9mIGEgZmV3IG1vcmUgYXRvbWljcyku IFRoaXMgaXMKPiBldmVuIG1vcmUgYmVuZWZpY2lhbCB3aGVuIHRoZSBsaWZldGltZSBvZiB0aGUg c3RhdGUgYmVjb21lcyBtb3JlCj4gY29udm9sdXRlZCB0aGFuIGJlaW5nIHBhc3NlZCB0byBhIHNp bmdsZSB3b3JrZXIgdGhyZWFkIGZvciB0aGUgY29tbWl0Lgo+IAo+IHYyOiBEb3VibGUgY2hlY2sg IWludGVsIGF0b21pY19jb21taXQgZnVuY3Rpb25zIGZvciBtaXNzaW5nIGdldHMKPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzog RGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiAtLS0KPiAgZHJpdmVycy9n cHUvZHJtL2F0bWVsLWhsY2RjL2F0bWVsX2hsY2RjX2RjLmMgfCAgMyArLQo+ICBkcml2ZXJzL2dw dS9kcm0vZHJtX2F0b21pYy5jICAgICAgICAgICAgICAgICB8IDIzICsrKy0tLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgICAgICAgICAgfCA5OCArKysrKysrLS0tLS0t LS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMgICAgICAg ICAgICAgIHwgIDkgKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9kcnYu YyAgICAgIHwgIDMgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgICAg ICAgICAgfCAgMyArLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgICAg ICAgICB8IDMyICsrKystLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUu YyAgICAgICAgICB8ICA0ICstCj4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Ry di5jICAgICAgIHwgIDMgKy0KPiAgZHJpdmVycy9ncHUvZHJtL21zbS9tc21fYXRvbWljLmMgICAg ICAgICAgICAgfCAgMyArLQo+ICBkcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5jICAg ICAgICAgICB8ICAzICstCj4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfa21zLmMg ICAgICAgIHwgIDMgKy0KPiAgZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfZHJ2LmMgICAgICAgICAg ICAgICAgfCAgMyArLQo+ICBkcml2ZXJzL2dwdS9kcm0vdGVncmEvZHJtLmMgICAgICAgICAgICAg ICAgICB8ICAzICstCj4gIGRyaXZlcnMvZ3B1L2RybS90aWxjZGMvdGlsY2RjX2Rydi5jICAgICAg ICAgIHwgIDIgLQo+ICBkcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9rbXMuYyAgICAgICAgICAgICAg ICB8ICAzICstCj4gIGluY2x1ZGUvZHJtL2RybV9hdG9taWMuaCAgICAgICAgICAgICAgICAgICAg IHwgMTIgKysrLQo+ICBpbmNsdWRlL2RybS9kcm1fY3J0Yy5oICAgICAgICAgICAgICAgICAgICAg ICB8ICAzICsKPiAgMTggZmlsZXMgY2hhbmdlZCwgODUgaW5zZXJ0aW9ucygrKSwgMTI4IGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYXRtZWwtaGxjZGMvYXRt ZWxfaGxjZGNfZGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9hdG1lbC1obGNkYy9hdG1lbF9obGNkY19k Yy5jCj4gaW5kZXggZDRhM2Q2MWI3YjA2Li4xNWE5ZjlkM2VmOWEgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2F0bWVsLWhsY2RjL2F0bWVsX2hsY2RjX2RjLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vYXRtZWwtaGxjZGMvYXRtZWxfaGxjZGNfZGMuYwo+IEBAIC00NjQsNyArNDY0LDcg QEAgYXRtZWxfaGxjZGNfZGNfYXRvbWljX2NvbXBsZXRlKHN0cnVjdCBhdG1lbF9obGNkY19kY19j b21taXQgKmNvbW1pdCkKPiAgCj4gIAlkcm1fYXRvbWljX2hlbHBlcl9jbGVhbnVwX3BsYW5lcyhk ZXYsIG9sZF9zdGF0ZSk7Cj4gIAo+IC0JZHJtX2F0b21pY19zdGF0ZV9mcmVlKG9sZF9zdGF0ZSk7 Cj4gKwlkcm1fYXRvbWljX3N0YXRlX3B1dChvbGRfc3RhdGUpOwo+ICAKPiAgCS8qIENvbXBsZXRl IHRoZSBjb21taXQsIHdha2UgdXAgYW55IHdhaXRlci4gKi8KPiAgCXNwaW5fbG9jaygmZGMtPmNv bW1pdC53YWl0LmxvY2spOwo+IEBAIC01MjEsNiArNTIxLDcgQEAgc3RhdGljIGludCBhdG1lbF9o bGNkY19kY19hdG9taWNfY29tbWl0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkvKiBTd2Fw IHRoZSBzdGF0ZSwgdGhpcyBpcyB0aGUgcG9pbnQgb2Ygbm8gcmV0dXJuLiAqLwo+ICAJZHJtX2F0 b21pY19oZWxwZXJfc3dhcF9zdGF0ZShzdGF0ZSwgdHJ1ZSk7Cj4gIAo+ICsJZHJtX2F0b21pY19z dGF0ZV9nZXQoc3RhdGUpOwo+ICAJaWYgKGFzeW5jKQo+ICAJCXF1ZXVlX3dvcmsoZGMtPndxLCAm Y29tbWl0LT53b3JrKTsKPiAgCWVsc2UKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9hdG9taWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiBpbmRleCA1Y2IyZTIy ZDVkNTUuLjM0OWMyZjBkZTkwMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+IEBAIC03NCw2ICs3 NCw4IEBAIEVYUE9SVF9TWU1CT0woZHJtX2F0b21pY19zdGF0ZV9kZWZhdWx0X3JlbGVhc2UpOwo+ ICBpbnQKPiAgZHJtX2F0b21pY19zdGF0ZV9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0 cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgewo+ICsJa3JlZl9pbml0KCZzdGF0ZS0+ cmVmKTsKPiArCj4gIAkvKiBUT0RPIGxlZ2FjeSBwYXRocyBzaG91bGQgbWF5YmUgZG8gYSBiZXR0 ZXIgam9iIGFib3V0Cj4gIAkgKiBzZXR0aW5nIHRoaXMgYXBwcm9wcmlhdGVseT8KPiAgCSAqLwo+ IEBAIC0yMTUsMjIgKzIxNywxNiBAQCB2b2lkIGRybV9hdG9taWNfc3RhdGVfY2xlYXIoc3RydWN0 IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ICBFWFBPUlRfU1lNQk9MKGRybV9hdG9taWNfc3Rh dGVfY2xlYXIpOwo+ICAKPiAgLyoqCj4gLSAqIGRybV9hdG9taWNfc3RhdGVfZnJlZSAtIGZyZWUg YWxsIG1lbW9yeSBmb3IgYW4gYXRvbWljIHN0YXRlCj4gKyAqIF9fZHJtX2F0b21pY19zdGF0ZV9m cmVlIC0gZnJlZSBhbGwgbWVtb3J5IGZvciBhbiBhdG9taWMgc3RhdGUKPiAgICogQHN0YXRlOiBh dG9taWMgc3RhdGUgdG8gZGVhbGxvY2F0ZQoKRG9jIGxpbmUgbmVlZHMgdXBkYXRpbmcgYXMgd2Vs bC4KT3RoZXIgdGhhbiB0aGF0LCB0aGlzIGxvb2tzIGdvb2QgdG8gbWU6ClJldmlld2VkLWJ5OiBF cmljIEVuZ2VzdHJvbSA8ZXJpYy5lbmdlc3Ryb21AaW1ndGVjLmNvbT4KCj4gICAqCj4gICAqIFRo aXMgZnJlZXMgYWxsIG1lbW9yeSBhc3NvY2lhdGVkIHdpdGggYW4gYXRvbWljIHN0YXRlLCBpbmNs dWRpbmcgYWxsIHRoZQo+ICAgKiBwZXItb2JqZWN0IHN0YXRlIGZvciBwbGFuZXMsIGNydGNzIGFu ZCBjb25uZWN0b3JzLgo+ICAgKi8KPiAtdm9pZCBkcm1fYXRvbWljX3N0YXRlX2ZyZWUoc3RydWN0 IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ICt2b2lkIF9fZHJtX2F0b21pY19zdGF0ZV9mcmVl KHN0cnVjdCBrcmVmICpyZWYpCj4gIHsKCltzbmlwXQpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK