From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: Amir Vadai <amir@vadai.me>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Jiri Benc <jbenc@redhat.com>,
Jiri Pirko <jiri@mellanox.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Tom Herbert <tom@herbertland.com>,
Hadar Har-Zion <hadarh@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>
Subject: Re: [PATCH net-next V2 2/4] net/dst: Utility functions to build dst_metadata without supplying an skb
Date: Wed, 24 Aug 2016 21:26:48 +0300 [thread overview]
Message-ID: <20160824212648.43c45295@halley> (raw)
In-Reply-To: <20160824122710.30356-3-amir@vadai.me>
Hi,
On Wed, 24 Aug 2016 15:27:08 +0300 Amir Vadai <amir@vadai.me> wrote:
> +static inline struct metadata_dst *
> +_ipv6_tun_rx_dst(struct in6_addr saddr, struct in6_addr daddr,
> + __u8 tos, __u8 ttl, __be32 label,
> + __be16 flags, __be64 tunnel_id, int md_size)
> +{
Prefer 'const struct in6_addr *saddr' parameter (daddr too).
This is aligned with almost all functions having an 'in6_addr' as a
parameter, to prevent the costy argument copy.
next prev parent reply other threads:[~2016-08-24 19:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 12:27 [PATCH net-next V2 0/4] net/sched: ip tunnel metadata set/release/classify by using TC Amir Vadai
2016-08-24 12:27 ` [PATCH net-next V2 1/4] net/ip_tunnels: Introduce tunnel_id_to_key32() and key32_to_tunnel_id() Amir Vadai
2016-08-24 18:15 ` Shmulik Ladkani
2016-08-24 12:27 ` [PATCH net-next V2 2/4] net/dst: Utility functions to build dst_metadata without supplying an skb Amir Vadai
2016-08-24 18:26 ` Shmulik Ladkani [this message]
2016-08-24 18:53 ` Shmulik Ladkani
2016-08-24 12:27 ` [PATCH net-next V2 3/4] net/sched: cls_flower: Classify packet in ip tunnels Amir Vadai
2016-08-24 12:27 ` [PATCH net-next V2 4/4] net/sched: Introduce act_tunnel_key Amir Vadai
2016-08-24 19:05 ` Shmulik Ladkani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160824212648.43c45295@halley \
--to=shmulik.ladkani@gmail.com \
--cc=amir@vadai.me \
--cc=davem@davemloft.net \
--cc=hadarh@mellanox.com \
--cc=jbenc@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.