From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 24 Aug 2016 17:11:09 -0700 From: Stephen Boyd To: Chanwoo Choi Cc: Sylwester Nawrocki , tomasz.figa@gmail.com, mturquette@baylibre.com, kgene@kernel.org, k.kozlowski@samsung.com, chanwoo@kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section Message-ID: <20160825001109.GO19826@codeaurora.org> References: <1471834185-20249-1-git-send-email-cw00.choi@samsung.com> <1471834185-20249-2-git-send-email-cw00.choi@samsung.com> <20160823005512.GP6502@codeaurora.org> <57BBB66E.2060807@samsung.com> <84e40b9b-1e08-24e0-f1ef-60b38b760ae6@samsung.com> <20160824044346.GR6502@codeaurora.org> <57BD5CFB.5050500@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <57BD5CFB.5050500@samsung.com> List-ID: On 08/24, Chanwoo Choi wrote: > On 2016년 08월 24일 13:43, Stephen Boyd wrote: > > On 08/23, Sylwester Nawrocki wrote: > >> So the saving is rather insignificant but the patch doesn't make > >> things worse and I'd say it might be worth applying. > >> > > > > Sounds good. This sort of information should be in the commit > > text though. Talking about const doesn't make any sense to me. > > Do you mean that 'const' is initconst secion? No. Marking it as initconst in the patch is correct. > If possible, could you explain the anything > why you don't make sense about 'const'? > I'm just saying that the reasoning to move it from the text section to the data section shouldn't be because of const. There should be better reasons to do this, like size benefits. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section Date: Wed, 24 Aug 2016 17:11:09 -0700 Message-ID: <20160825001109.GO19826@codeaurora.org> References: <1471834185-20249-1-git-send-email-cw00.choi@samsung.com> <1471834185-20249-2-git-send-email-cw00.choi@samsung.com> <20160823005512.GP6502@codeaurora.org> <57BBB66E.2060807@samsung.com> <84e40b9b-1e08-24e0-f1ef-60b38b760ae6@samsung.com> <20160824044346.GR6502@codeaurora.org> <57BD5CFB.5050500@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <57BD5CFB.5050500@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Chanwoo Choi Cc: k.kozlowski@samsung.com, linux-samsung-soc@vger.kernel.org, Sylwester Nawrocki , mturquette@baylibre.com, tomasz.figa@gmail.com, linux-kernel@vger.kernel.org, kgene@kernel.org, chanwoo@kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org T24gMDgvMjQsIENoYW53b28gQ2hvaSB3cm90ZToKPiBPbiAyMDE264WEIDA47JuUIDI07J28IDEz OjQzLCBTdGVwaGVuIEJveWQgd3JvdGU6Cj4gPiBPbiAwOC8yMywgU3lsd2VzdGVyIE5hd3JvY2tp IHdyb3RlOgo+ID4+IFNvIHRoZSBzYXZpbmcgaXMgcmF0aGVyIGluc2lnbmlmaWNhbnQgYnV0IHRo ZSBwYXRjaCBkb2Vzbid0IG1ha2UKPiA+PiB0aGluZ3Mgd29yc2UgYW5kIEknZCBzYXkgaXQgbWln aHQgYmUgd29ydGggYXBwbHlpbmcuCj4gPj4KPiA+IAo+ID4gU291bmRzIGdvb2QuIFRoaXMgc29y dCBvZiBpbmZvcm1hdGlvbiBzaG91bGQgYmUgaW4gdGhlIGNvbW1pdAo+ID4gdGV4dCB0aG91Z2gu IFRhbGtpbmcgYWJvdXQgY29uc3QgZG9lc24ndCBtYWtlIGFueSBzZW5zZSB0byBtZS4KPiAKPiBE byB5b3UgbWVhbiB0aGF0ICdjb25zdCcgaXMgaW5pdGNvbnN0IHNlY2lvbj8KCk5vLiBNYXJraW5n IGl0IGFzIGluaXRjb25zdCBpbiB0aGUgcGF0Y2ggaXMgY29ycmVjdC4KCj4gSWYgcG9zc2libGUs IGNvdWxkIHlvdSBleHBsYWluIHRoZSBhbnl0aGluZwo+IHdoeSB5b3UgZG9uJ3QgbWFrZSBzZW5z ZSBhYm91dCAnY29uc3QnPwo+IAoKSSdtIGp1c3Qgc2F5aW5nIHRoYXQgdGhlIHJlYXNvbmluZyB0 byBtb3ZlIGl0IGZyb20gdGhlIHRleHQKc2VjdGlvbiB0byB0aGUgZGF0YSBzZWN0aW9uIHNob3Vs ZG4ndCBiZSBiZWNhdXNlIG9mIGNvbnN0LiBUaGVyZQpzaG91bGQgYmUgYmV0dGVyIHJlYXNvbnMg dG8gZG8gdGhpcywgbGlrZSBzaXplIGJlbmVmaXRzLgoKLS0gClF1YWxjb21tIElubm92YXRpb24g Q2VudGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9mIENvZGUgQXVyb3JhIEZvcnVtLAphIExpbnV4IEZv dW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQcm9qZWN0CgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Wed, 24 Aug 2016 17:11:09 -0700 Subject: [PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section In-Reply-To: <57BD5CFB.5050500@samsung.com> References: <1471834185-20249-1-git-send-email-cw00.choi@samsung.com> <1471834185-20249-2-git-send-email-cw00.choi@samsung.com> <20160823005512.GP6502@codeaurora.org> <57BBB66E.2060807@samsung.com> <84e40b9b-1e08-24e0-f1ef-60b38b760ae6@samsung.com> <20160824044346.GR6502@codeaurora.org> <57BD5CFB.5050500@samsung.com> Message-ID: <20160825001109.GO19826@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/24, Chanwoo Choi wrote: > On 2016? 08? 24? 13:43, Stephen Boyd wrote: > > On 08/23, Sylwester Nawrocki wrote: > >> So the saving is rather insignificant but the patch doesn't make > >> things worse and I'd say it might be worth applying. > >> > > > > Sounds good. This sort of information should be in the commit > > text though. Talking about const doesn't make any sense to me. > > Do you mean that 'const' is initconst secion? No. Marking it as initconst in the patch is correct. > If possible, could you explain the anything > why you don't make sense about 'const'? > I'm just saying that the reasoning to move it from the text section to the data section shouldn't be because of const. There should be better reasons to do this, like size benefits. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project