From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH 7/7] vhost: simplify features set/get
Date: Thu, 25 Aug 2016 11:03:19 +0800
Message-ID: <20160825030319.GV30752@yliu-dev.sh.intel.com>
References: <1471510123-4984-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1471510123-4984-8-git-send-email-yuanhan.liu@linux.intel.com>
 <33936312-b630-1a4e-e478-b028dc264962@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 16177592F
 for <dev@dpdk.org>; Thu, 25 Aug 2016 04:53:18 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <33936312-b630-1a4e-e478-b028dc264962@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Aug 24, 2016 at 10:11:57AM +0200, Maxime Coquelin wrote:
> 
> 
> On 08/18/2016 10:48 AM, Yuanhan Liu wrote:
> >No need to use a pointer to store/retrieve features.
> >
> >Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> >---
> > lib/librte_vhost/vhost_user.c | 20 ++++++++------------
> > 1 file changed, 8 insertions(+), 12 deletions(-)
> >
> >diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
> >index ef4a0c1..eee99e9 100644
> >--- a/lib/librte_vhost/vhost_user.c
> >+++ b/lib/librte_vhost/vhost_user.c
> >@@ -155,23 +155,22 @@ vhost_user_reset_owner(struct virtio_net *dev)
> > /*
> >  * The features that we support are requested.
> >  */
> >-static int
> >-vhost_user_get_features(uint64_t *pu)
> >+static uint64_t
> >+vhost_user_get_features(void)
> > {
> >-	*pu = VHOST_FEATURES;
> >-	return 0;
> >+	return VHOST_FEATURES;
> > }
> 
> This is not the topic of this series, but I wonder if it
> could make sense to be able to override supported features
> at device init time.

Not quite sure I understood it correctly: is rte_vhost_feature_disable()
the answer you are looking for?

> It may not match with the orignal purpose of supported features,
> but could be useful at least for testing without recompilation.
> 
> For this patch:
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Again, appreicate your time on review!

	--yliu