Re: [PATCH v3 06/15] IB/pvrdma: Add helper functions

[Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]

On Thu, Aug 25, 2016 at 09:16:43AM +0300, Yuval Shaia wrote:
> > +
> > +void pvrdma_gid_to_ib(const union pvrdma_gid *src, union ib_gid *dst)
> > +{
> > +	BUILD_BUG_ON(sizeof(union pvrdma_gid) != sizeof(union ib_gid));
> > +	memcpy(dst, src, sizeof(*src));
> 
> If we enforce size-computability then can you consider return cast of *src
> instead of doing memcpy?

Please ignore this one.
Looking at usage of this function i don't think you want to do it.
But suggesting to rename the function to something that will imply that you
actually copying and not just convening.

> 
> > +}
> > +
> > +void ib_gid_to_pvrdma(const union ib_gid *src, union pvrdma_gid *dst)
> > +{
> > +	BUILD_BUG_ON(sizeof(union pvrdma_gid) != sizeof(union ib_gid));
> > +	memcpy(dst, src, sizeof(*src));
> 
> Ditto.
> 
> > +}
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html