From: Wei Liu <wei.liu2@citrix.com>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: sstabellini@kernel.org, Wei Liu <wei.liu2@citrix.com>,
ian.jackson@eu.citrix.com, peter.huangpeng@huawei.com,
xen-devel@lists.xen.org, julien.grall@arm.com,
shannon.zhao@linaro.org, boris.ostrovsky@oracle.com
Subject: Re: [PATCH v4 01/16] tools/libxl: Add an unified configuration option for ACPI
Date: Thu, 25 Aug 2016 10:05:43 +0100 [thread overview]
Message-ID: <20160825090543.GP20641@citrix.com> (raw)
In-Reply-To: <57BEA438.8060106@huawei.com>
On Thu, Aug 25, 2016 at 03:54:32PM +0800, Shannon Zhao wrote:
>
>
> On 2016/8/24 20:50, Wei Liu wrote:
> >> - localents[i++] = libxl_defbool_val(info->u.hvm.acpi) ? "1" : "0";
> >> > + localents[i++] = (libxl_defbool_val(info->acpi) &&
> >> > + libxl_defbool_val(info->u.hvm.acpi)) ? "1" : "0";
> > Please provide a function for this.
> >
> > And the logic doesn't seem right. If the user sets u.hvm.acpi only,
> > (s)he should still have ACPI enabled.
> info->acpi is true by defaut, so if user doesn't set info->acpi while
> sets u.hvm.acpi only, both u.hvm.acpi and info->acpi will be true IIUC.
OK, that sounds sensible. But please could you document this expectation
in the to-be-created helper function? Thanks.
Wei.
>
> Thanks,
> --
> Shannon
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-25 9:05 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 10:24 [PATCH v4 00/16] Xen ARM DomU ACPI support Shannon Zhao
2016-08-16 10:24 ` [PATCH v4 01/16] tools/libxl: Add an unified configuration option for ACPI Shannon Zhao
2016-08-18 16:16 ` Julien Grall
2016-08-24 12:50 ` Wei Liu
2016-08-25 7:54 ` Shannon Zhao
2016-08-25 9:05 ` Wei Liu [this message]
2016-08-25 9:09 ` Shannon Zhao
2016-08-16 10:24 ` [PATCH v4 02/16] libxl/arm: prepare for constructing ACPI tables Shannon Zhao
2016-08-18 16:36 ` Julien Grall
2016-08-16 10:25 ` [PATCH v4 03/16] libxl/arm: Generate static ACPI DSDT table Shannon Zhao
2016-08-24 21:52 ` Boris Ostrovsky
2016-08-29 17:46 ` Julien Grall
2016-08-31 6:37 ` Shannon Zhao
2016-08-31 9:58 ` Julien Grall
2016-08-31 18:51 ` Stefano Stabellini
2016-09-01 3:18 ` Shannon Zhao
2016-09-01 12:53 ` Boris Ostrovsky
2016-09-02 0:55 ` Shannon Zhao
2016-09-02 1:12 ` Boris Ostrovsky
2016-08-16 10:25 ` [PATCH v4 04/16] libxl/arm: Estimate the size of ACPI tables Shannon Zhao
2016-08-16 10:25 ` [PATCH v4 05/16] libxl/arm: Construct ACPI RSDP table Shannon Zhao
2016-08-24 12:52 ` Wei Liu
2016-08-25 8:05 ` Shannon Zhao
2016-08-25 9:05 ` Wei Liu
2016-08-29 18:05 ` Julien Grall
2016-08-30 1:21 ` Shannon Zhao
2016-08-30 17:11 ` Julien Grall
2016-08-30 21:38 ` Stefano Stabellini
2016-08-29 18:03 ` Julien Grall
2016-08-16 10:25 ` [PATCH v4 06/16] libxl/arm: Construct ACPI XSDT table Shannon Zhao
2016-08-29 18:10 ` Julien Grall
2016-08-16 10:25 ` [PATCH v4 07/16] libxl/arm: Construct ACPI GTDT table Shannon Zhao
2016-08-24 12:56 ` Wei Liu
2016-08-24 14:13 ` Roger Pau Monné
2016-08-25 7:58 ` Shannon Zhao
2016-08-29 18:16 ` Julien Grall
2016-08-30 1:36 ` Shannon Zhao
2016-08-16 10:25 ` [PATCH v4 08/16] libxl/arm: Factor MPIDR computing codes out as a helper Shannon Zhao
2016-08-29 18:17 ` Julien Grall
2016-08-16 10:25 ` [PATCH v4 09/16] libxl/arm: Construct ACPI MADT table Shannon Zhao
2016-08-29 18:30 ` Julien Grall
2016-08-16 10:25 ` [PATCH v4 10/16] libxl/arm: Construct ACPI FADT table Shannon Zhao
2016-08-29 18:38 ` Julien Grall
2016-08-16 10:25 ` [PATCH v4 11/16] libxl/arm: Construct ACPI DSDT table Shannon Zhao
2016-08-16 10:25 ` [PATCH v4 12/16] libxl/arm: Factor finalise_one_memory_node as a gerneric function Shannon Zhao
2016-08-29 18:39 ` Julien Grall
2016-08-16 10:25 ` [PATCH v4 13/16] libxl/arm: Add ACPI module Shannon Zhao
2016-08-29 18:41 ` Julien Grall
2016-08-16 10:25 ` [PATCH v4 14/16] public/hvm/params.h: Add macros for HVM_PARAM_CALLBACK_TYPE_PPI Shannon Zhao
2016-08-24 13:06 ` Wei Liu
2016-08-24 13:15 ` Jan Beulich
2016-08-24 22:27 ` Boris Ostrovsky
2016-08-29 19:00 ` Julien Grall
2016-08-30 1:30 ` Shannon Zhao
2016-08-16 10:25 ` [PATCH v4 15/16] libxl/arm: Initialize domain param HVM_PARAM_CALLBACK_IRQ Shannon Zhao
2016-08-16 10:25 ` [PATCH v4 16/16] libxl/arm: Add the size of ACPI tables to maxmem Shannon Zhao
2016-08-29 19:07 ` Julien Grall
2016-08-30 1:25 ` Shannon Zhao
2016-08-30 8:29 ` Wei Liu
2016-08-30 9:20 ` Shannon Zhao
2016-08-24 12:58 ` [PATCH v4 00/16] Xen ARM DomU ACPI support Wei Liu
2016-08-25 8:01 ` Shannon Zhao
2016-08-29 19:08 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825090543.GP20641@citrix.com \
--to=wei.liu2@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=peter.huangpeng@huawei.com \
--cc=shannon.zhao@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.