From: Benjamin Berg <benjamin@sipsolutions.net>
To: ath10k@lists.infradead.org
Cc: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>,
Benjamin Berg <benjamin@sipsolutions.net>,
Michal Kazior <michal.kazior@tieto.com>,
Sebastian Gottschall <s.gottschall@dd-wrt.com>
Subject: [PATCHv3 0/2] ath10k: Allow setting coverage class
Date: Thu, 25 Aug 2016 15:25:20 +0200 [thread overview]
Message-ID: <20160825132522.30994-1-benjamin@sipsolutions.net> (raw)
Hi,
This revision of the patch has quite a number of changes, most notably the
handler to set the registers is now called from a work queue after a WMI
event.
The reason for this is that Sebastian reported that at least the WAVE2
chipsets do not behave well when the calls happen before the hardware is
initialized. This means we need to check ar->state, which in turn is
protected by conf_mutex, so the task is now pushed to the general work
queue to prevent having to hold the lock during the WMI event processing.
Changes in v3:
* Only update register values if hardware is initialized
* Use the SM/MS macros instead of manual bitshifts and masks
* Use the hardware phyclk register instead of assuming a clock speed
* Force dbglog_mask of ~0 and dbglog_level of at least WARN if active
* Only call code for selected WMI events
The last two items are a bit of a guess for me. In particular it looks like
the default log level is already WARN, but I suppose that this should be good
enough to get reports for internal chip resets. I have no way of verifying
this myself though.
Changes in v2 were:
* Move code into hw.c and run from new hw_ops depending on chip revision
* Error message corrections
The patch assumes that a new hw_ops struct exists based on work by
Vasanthakumar. The rename patch is on top of "ath10k: Add provision for
Rx descriptor abstraction" and adjustment in either patchset will be
neccessary for merging.
What are the plans with regard to getting those patches merged (ath10k:
Padding related clean ups in rx)?
Benjamin Berg (2):
ath10k: Rename hw_rx_desc_ops to hw_ops to use it for other purposes
ath10k: Allow setting coverage class
drivers/net/wireless/ath/ath10k/core.c | 35 +++++---
drivers/net/wireless/ath/ath10k/core.h | 12 +++
drivers/net/wireless/ath/ath10k/hw.c | 143 ++++++++++++++++++++++++++++++++-
drivers/net/wireless/ath/ath10k/hw.h | 36 +++++++--
drivers/net/wireless/ath/ath10k/mac.c | 19 +++++
drivers/net/wireless/ath/ath10k/wmi.c | 37 +++++++++
6 files changed, 263 insertions(+), 19 deletions(-)
--
2.9.3
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next reply other threads:[~2016-08-25 13:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 13:25 Benjamin Berg [this message]
2016-08-25 13:25 ` [PATCHv3 1/2] ath10k: Rename hw_rx_desc_ops to hw_ops to use it for other purposes Benjamin Berg
2016-08-25 13:25 ` [PATCHv3 2/2] ath10k: Allow setting coverage class Benjamin Berg
2016-08-25 14:28 ` Ben Greear
2016-08-25 14:33 ` Benjamin Berg
2016-08-25 15:10 ` Sebastian Gottschall
2017-10-16 17:57 ` Ben Greear
2017-10-16 17:59 ` Adrian Chadd
2017-10-16 19:10 ` Sebastian Gottschall
2017-10-16 19:12 ` Adrian Chadd
2017-10-16 19:55 ` Ben Greear
2017-10-17 7:57 ` Sebastian Gottschall
2017-10-17 7:56 ` Sebastian Gottschall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825132522.30994-1-benjamin@sipsolutions.net \
--to=benjamin@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=michal.kazior@tieto.com \
--cc=s.gottschall@dd-wrt.com \
--cc=vthiagar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.