From: Anson Jacob <ansonjacob.aj@gmail.com>
To: Andrey Utkin <andrey_utkin@fastmail.com>
Cc: gregkh@linuxfoundation.org, abbotti@mev.co.uk,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] staging: comedi: ni_at_a2150.c: Fix checkpatch warning
Date: Thu, 25 Aug 2016 12:09:23 -0400 [thread overview]
Message-ID: <20160825160923.GA6998@X250> (raw)
In-Reply-To: <20160825154708.a55hsffnfdz2zqac@acer>
Thank you for your comments.
On Thu, Aug 25, 2016 at 06:47:08PM +0300, Andrey Utkin wrote:
>
> > +#define CHANNEL_BITS(x) ((x) & 0x7)
> > +#define CHANNEL_MASK 0x7
>
> No uniform alignment. Please get everything in a row.
> If it's hard or this part of driver is expected to have a lot of changes
> in near future, then I'd remove any whitespace over single space between
> name and value.
>
I didn't get your point in this case. Could you explain it.
next prev parent reply other threads:[~2016-08-25 16:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 15:14 [PATCH 0/6] staging: comedi: cb_pcidas64.c: Fix checkpatch warning Anson Jacob
2016-08-25 15:15 ` [PATCH 1/6] " Anson Jacob
2016-08-25 15:15 ` [PATCH 2/6] staging: comedi: jr3_pci.h: " Anson Jacob
2016-08-25 15:15 ` [PATCH 3/6] staging: comedi: ni_atmio.c: " Anson Jacob
2016-08-25 15:15 ` [PATCH 4/6] staging: comedi: s626.h: " Anson Jacob
2016-08-25 15:15 ` [PATCH 5/6] staging: comedi: jr3_pci.c: " Anson Jacob
2016-08-25 15:16 ` [PATCH 6/6] staging: comedi: ni_at_a2150.c: " Anson Jacob
2016-08-25 15:47 ` Andrey Utkin
2016-08-25 16:09 ` Anson Jacob [this message]
2016-08-25 16:18 ` Andrey Utkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825160923.GA6998@X250 \
--to=ansonjacob.aj@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=andrey_utkin@fastmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.