From: Wolfram Sang <wsa@the-dreams.de>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Guenter Roeck <linux@roeck-us.net>,
"David S. Miller" <davem@davemloft.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
Crestez Dan Leonard <leonard.crestez@intel.com>
Subject: Re: [PATCH v2 6/8] i2c: mux: inform the i2c mux core about how it is used
Date: Thu, 25 Aug 2016 18:24:32 +0200 [thread overview]
Message-ID: <20160825162432.GF2856@katana> (raw)
In-Reply-To: <856c696f-b0c4-63f0-ee50-1b96556cf6e0@axentia.se>
[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
On Thu, Aug 25, 2016 at 06:22:37PM +0200, Peter Rosin wrote:
> On 2016-08-25 18:19, Wolfram Sang wrote:
> >
> >> diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c
> >> index 3cb8af635db5..f052c3067791 100644
> >> --- a/drivers/i2c/muxes/i2c-mux-pca9541.c
> >> +++ b/drivers/i2c/muxes/i2c-mux-pca9541.c
> >> @@ -349,7 +349,8 @@ static int pca9541_probe(struct i2c_client *client,
> >> force = 0;
> >> if (pdata)
> >> force = pdata->modes[0].adap_id;
> >> - muxc = i2c_mux_alloc(adap, &client->dev, 1, sizeof(*data), 0,
> >> + muxc = i2c_mux_alloc(adap, &client->dev, 1, sizeof(*data),
> >> + I2C_MUX_ARBITRATOR,
> >
> > Does it make sense to rename the file to i2c-arb-* somewhen then? Just
> > asking, I'll apply the patch anyhow.
>
> There should be a clean branch with /only/ this series that both i2c and
> iio can share, to prevent merge problems. I said I'd make such a branch
> in the i2c-mux repo, but you are of course also welcome to provide that
> branch if you prefer...
No, this is fine. Send me a pull request and I'll merge.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-25 16:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 13:40 [PATCH v2 0/8] devicetree cleanup for i2c muxes/arbs/gates Peter Rosin
2016-08-15 13:40 ` Peter Rosin
[not found] ` <1471268431-5148-1-git-send-email-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
2016-08-15 13:40 ` [PATCH v2 1/8] dt-bindings: i2c: add support for 'i2c-mux' subnode Peter Rosin
2016-08-15 13:40 ` Peter Rosin
2016-08-15 13:40 ` [PATCH v2 2/8] dt-bindings: i2c: add support for 'i2c-arb' subnode Peter Rosin
2016-08-15 13:40 ` Peter Rosin
2016-08-15 13:40 ` [PATCH v2 3/8] dt-bindings: i2c: add support for 'i2c-gate' subnode Peter Rosin
2016-08-15 13:40 ` Peter Rosin
[not found] ` <1471268431-5148-4-git-send-email-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
2016-08-16 13:57 ` Rob Herring
2016-08-16 13:57 ` Rob Herring
2016-08-25 16:15 ` Wolfram Sang
2016-08-15 13:40 ` [PATCH v2 4/8] dt-bindings: i2c: add bindings for nxp,pca9541 Peter Rosin
2016-08-15 13:40 ` Peter Rosin
2016-08-15 13:40 ` [PATCH v2 5/8] i2c: mux: add support for 'i2c-mux', 'i2c-arb' and 'i2c-gate' DT subnodes Peter Rosin
2016-08-15 13:40 ` Peter Rosin
[not found] ` <1471268431-5148-6-git-send-email-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
2016-08-15 13:55 ` Vladimir Zapolskiy
2016-08-15 13:55 ` Vladimir Zapolskiy
2016-08-15 14:33 ` Peter Rosin
2016-08-15 14:33 ` Peter Rosin
2016-08-15 13:40 ` [PATCH v2 6/8] i2c: mux: inform the i2c mux core about how it is used Peter Rosin
2016-08-15 13:40 ` Peter Rosin
[not found] ` <1471268431-5148-7-git-send-email-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
2016-08-25 16:19 ` Wolfram Sang
2016-08-25 16:19 ` Wolfram Sang
2016-08-25 16:22 ` Peter Rosin
2016-08-25 16:22 ` Peter Rosin
2016-08-25 16:24 ` Wolfram Sang [this message]
2016-08-25 16:28 ` Peter Rosin
2016-08-25 16:28 ` Peter Rosin
[not found] ` <2e5539ad-4ad6-e61e-75c5-163c91b3ec41-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
2016-08-25 16:38 ` Wolfram Sang
2016-08-25 16:38 ` Wolfram Sang
2016-08-15 13:40 ` [PATCH v2 7/8] i2c: pca9541: add device tree binding Peter Rosin
2016-08-15 13:40 ` Peter Rosin
2016-08-15 13:40 ` [PATCH v2 8/8] i2c: pca954x: " Peter Rosin
2016-08-15 13:40 ` Peter Rosin
2016-08-25 16:22 ` [PATCH v2 0/8] devicetree cleanup for i2c muxes/arbs/gates Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825162432.GF2856@katana \
--to=wsa@the-dreams.de \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=leonard.crestez@intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.