Re: [PATCH] Input: joydev - Recognize joysticks with Z axis as joysticks.

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Thu, Aug 25, 2016 at 05:16:50PM +0300, Ville Ranki wrote:
> Current implementation of joydev's input_device_id
> table recognizes only devices with ABS_X, ABS_WHEEL
> or ABS_THROTTLE axes as joysticks.
> 
> There are joystick devices that do not have those axes,
> for example TRC Rudder device. The device in question
> has ABS_Z, ABS_RX and ABS_RY axes causing it not being
> detected as joystick.
> 
> This patch adds ABS_Z to the input_device_id list
> allowing devices with ABS_Z axis to be detected
> correctly.

I am curious why you still use joydev and not switch your client(s) to
evdev? Or is it some legacy game?

Thanks.

> 
> Signed-off-by: Ville Ranki <ville.ranki@iki.fi>
> ---
>  drivers/input/joydev.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/input/joydev.c b/drivers/input/joydev.c
> index 5d11fea..f3135ae 100644
> --- a/drivers/input/joydev.c
> +++ b/drivers/input/joydev.c
> @@ -950,6 +950,12 @@ static const struct input_device_id joydev_ids[] = {
>  		.flags = INPUT_DEVICE_ID_MATCH_EVBIT |
>  				INPUT_DEVICE_ID_MATCH_ABSBIT,
>  		.evbit = { BIT_MASK(EV_ABS) },
> +		.absbit = { BIT_MASK(ABS_Z) },
> +	},
> +	{
> +		.flags = INPUT_DEVICE_ID_MATCH_EVBIT |
> +				INPUT_DEVICE_ID_MATCH_ABSBIT,
> +		.evbit = { BIT_MASK(EV_ABS) },
>  		.absbit = { BIT_MASK(ABS_WHEEL) },
>  	},
>  	{
> -- 
> 2.7.4
> 

-- 
Dmitry