From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] fix to use index to HW queue assigned to PF instead of queus 0 - nb_rx_queues which belong to VF in SR-IOV configuration Date: Fri, 26 Aug 2016 08:57:10 -0700 Message-ID: <20160826085710.7466dfe3@xeon-e3> References: <1472206161-14601-1-git-send-email-alexz@att.com> <57C0202C.3010601@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: azelezniak , dev@dpdk.org, wenzhuo.lu@intel.com To: Ferruh Yigit Return-path: Received: from mail-pf0-f176.google.com (mail-pf0-f176.google.com [209.85.192.176]) by dpdk.org (Postfix) with ESMTP id 1D744FE5 for ; Fri, 26 Aug 2016 17:56:59 +0200 (CEST) Received: by mail-pf0-f176.google.com with SMTP id y134so29869640pfg.0 for ; Fri, 26 Aug 2016 08:56:59 -0700 (PDT) In-Reply-To: <57C0202C.3010601@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 26 Aug 2016 11:55:40 +0100 Ferruh Yigit wrote: > Hi Alex, >=20 > On 8/26/2016 11:09 AM, azelezniak wrote: > > From: Alex Zelezniak > >=20 > > Signed-off-by: Alex Zelezniak > > --- =20 >=20 > Thank you for the patch, not related to the patch content but related to > the patch format: > patch subject is too long, it is expected to be around 50 characters, > can you please move some of information to the patch commit log? >=20 > Also since this is a fix, commit log requires a Fixes line. >=20 > More details on: > http://dpdk.org/doc/guides/contributing/patches.html#sending-patches >=20 > Thanks, > ferruh >=20 The subject line of the patch email becomes the first line of the git commit message. This also documented on 'git commit' man page. DISCUSSION Though not required, it=E2=80=99s a good idea to begin the commit me= ssage with a single short (less than 50 character) line summarizing the change, followed by a blank line and then a more thorough description. Overly long summary lines are flagged as errors by tools like Debian lintia= n.