From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Rik van Riel <riel@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bug: avoid Kconfig warning for BUG_ON_DATA_CORRUPTION
Date: Fri, 26 Aug 2016 09:08:23 -0700 [thread overview]
Message-ID: <20160826160823.GF19706@linux.vnet.ibm.com> (raw)
In-Reply-To: <1472226423.2751.57.camel@redhat.com>
On Fri, Aug 26, 2016 at 11:47:03AM -0400, Rik van Riel wrote:
> On Fri, 2016-08-26 at 17:42 +0200, Arnd Bergmann wrote:
> > The CONFIG_DEBUG_LIST option is normally meant for kernel developers
> > rather than production machines and is guarded by
> > CONFIG_DEBUG_KERNEL.
> >
> > In contrast, the newly added CONFIG_BUG_ON_DATA_CORRUPTION is meant
> > for security hardening and may be used on systems that intentionally
> > do not enable CONFIG_DEBUG_KERNEL. In this configuration, we get
> > a warning from Kconfig about the mismatched dependencies:
> >
> > warning: (BUG_ON_DATA_CORRUPTION) selects DEBUG_LIST which has unmet
> > direct dependencies (DEBUG_KERNEL)
> >
> > This annotates the DEBUG_LIST option to be selectable by
> > BUG_ON_DATA_CORRUPTION when DEBUG_KERNEL is disabled.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 40cd725cfc7f ("bug: Provide toggle for BUG on data
> > corruption")
> >
> Acked-by: Rik van Riel <riel@redhat.com>
Queued for further review and testing, thank you both!
I expect to push this into the upcoming merge window, given that it
fixes a bug in my current stack of commits.
Thanx, Paul
prev parent reply other threads:[~2016-08-26 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 15:42 [PATCH] bug: avoid Kconfig warning for BUG_ON_DATA_CORRUPTION Arnd Bergmann
2016-08-26 15:47 ` Rik van Riel
2016-08-26 16:08 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160826160823.GF19706@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.