From: Anson Jacob <ansonjacob.aj@gmail.com>
To: Andrey Utkin <andrey_utkin@fastmail.com>
Cc: gregkh@linuxfoundation.org, abbotti@mev.co.uk,
hsweeten@visionengravers.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] staging: comedi: jr3_pci.h: Fix checkpatch warning
Date: Fri, 26 Aug 2016 18:35:51 -0400 [thread overview]
Message-ID: <20160826223551.GA3318@X250> (raw)
In-Reply-To: <20160826212358.dz4qy7ctgawyuxpa@acer>
On Sat, Aug 27, 2016 at 12:23:58AM +0300, Andrey Utkin wrote:
> On Fri, Aug 26, 2016 at 02:33:08PM -0400, Anson Jacob wrote:
> >
> > - /* Default_FS contains the full scale that is used if the user does */
> > - /* not set a full scale. */
> > + /*
>
> Applying: staging: comedi: jr3_pci.h: Fix checkpatch warning
> .git/rebase-apply/patch:226: trailing whitespace.
> /*
> warning: 1 line adds whitespace errors.
>
> This means you have a space after asterisk. You would catch this if you run
> checkpatch.pl after making your commits.
>
> Actually, some files you have amended, still have issues of same difficulty.
> You are encouraged to sort that out, too. See
>
> for x in drivers/staging/comedi/drivers/cb_pcidas64.c drivers/staging/comedi/drivers/jr3_pci.c drivers/staging/comedi/drivers/jr3_pci.h drivers/staging/comedi/drivers/ni_at_a2150.c drivers/staging/comedi/drivers/ni_atmio.c drivers/staging/comedi/drivers/s626.h; do ./scripts/checkpatch.pl --strict -f $x; done
Thank you for the comments and the code snippet.
I only found one trailing whitespace issue in the patchset.
I will be uploading a new patchset with the fix for the trailing whitespace.
Are my commits are too long. Am I supposed to submit shorter ones.
next prev parent reply other threads:[~2016-08-26 22:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 18:32 [PATCH v2 0/7] staging: comedi: Fix checkpatch warning Anson Jacob
2016-08-26 18:32 ` [PATCH v2 1/7] staging: comedi: cb_pcidas64.c: " Anson Jacob
2016-08-26 18:32 ` [PATCH v2 2/7] staging: comedi: cb_pcidas64: Fix commenting style Anson Jacob
2016-08-26 18:33 ` [PATCH v2 3/7] staging: comedi: jr3_pci.h: Fix checkpatch warning Anson Jacob
2016-08-26 21:23 ` Andrey Utkin
2016-08-26 22:35 ` Anson Jacob [this message]
2016-08-26 22:50 ` Andrey Utkin
2016-08-26 18:33 ` [PATCH v2 4/7] staging: comedi: ni_atmio.c: " Anson Jacob
2016-08-26 18:33 ` [PATCH v2 5/7] staging: comedi: s626.h: " Anson Jacob
2016-08-26 18:33 ` [PATCH v2 6/7] staging: comedi: jr3_pci.c: " Anson Jacob
2016-08-26 18:33 ` [PATCH v2 7/7] staging: comedi: ni_at_a2150: " Anson Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160826223551.GA3318@X250 \
--to=ansonjacob.aj@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=andrey_utkin@fastmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.