All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/kmsxx: add patch to fix LTO support
Date: Sat, 27 Aug 2016 09:22:07 +0200	[thread overview]
Message-ID: <20160827092207.17b2bf79@free-electrons.com> (raw)
In-Reply-To: <20160826213442.19246-1-arnout@mind.be>

Hello,

On Fri, 26 Aug 2016 23:34:42 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> The LTO support in the kmsxx package uses the host gcc-ar and gcc-ranlib
> instead of the ones from the cross-toolchain. Add a patch that tries to
> find the right one based on CMAKE_C_COMPILER.

Thanks for this patch! One quick question though.

> +     if (HAS_LTO_FLAG)
> +-        set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -flto")
> +-        set(CMAKE_AR gcc-ar)
> +-        set(CMAKE_RANLIB gcc-ranlib)
> ++        find_program(LTO_AR NAMES "${CMAKE_C_COMPILER}-ar" gcc-ar)
> ++        find_program(LTO_RANLIB NAMES "${CMAKE_C_COMPILER}-ranlib" /usr/bin/gcc-ranlib)

Why is the last attempted value for AR "gcc-ar", and for RANLIB it's
"/usr/bin/gcc-ranlib" ? I.e while just the program name in one case,
and a full path in the other case.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-08-27  7:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26 21:34 [Buildroot] [PATCH] package/kmsxx: add patch to fix LTO support Arnout Vandecappelle
2016-08-27  7:22 ` Thomas Petazzoni [this message]
2016-08-27 10:21   ` Arnout Vandecappelle
2016-08-27  9:03 ` Samuel Martin
2016-08-27 10:40   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160827092207.17b2bf79@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.