From: Greg KH <gregkh@linuxfoundation.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: dan.carpenter@oracle.com, linux-kernel@vger.kernel.org,
arnd@linaro.org, xie.baoyou@zte.com.cn
Subject: Re: [PATCH] fix:memory:of_memory:add missing header dependencies
Date: Sat, 27 Aug 2016 19:54:41 +0200 [thread overview]
Message-ID: <20160827175441.GC32072@kroah.com> (raw)
In-Reply-To: <1472319088-18701-1-git-send-email-baoyou.xie@linaro.org>
On Sun, Aug 28, 2016 at 01:31:28AM +0800, Baoyou Xie wrote:
> We get 2 warnings when biuld kernel with W=1:
Why would you do that?
> drivers/memory/of_memory.c:30:30: warning: no previous prototype for 'of_get_min_tck' [-Wmissing-prototypes]
> drivers/memory/of_memory.c:106:30: warning: no previous prototype for 'of_get_ddr_timings' [-Wmissing-prototypes]
>
> In fact, these functions are declared in drivers/memory/of_memory.h
> so this patch add missing header dependencies.
Why am I not seeing this warning on a "normal" build? If there's no
prototype of a function, that seems odd... What about sparse, does that
give you the same error here?
thanks,
greg k-h
prev parent reply other threads:[~2016-08-27 17:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 17:31 [PATCH] fix:memory:of_memory:add missing header dependencies Baoyou Xie
2016-08-27 17:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160827175441.GC32072@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@linaro.org \
--cc=baoyou.xie@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.