From mboxrd@z Thu Jan  1 00:00:00 1970
From: jolsa@redhat.com (Jiri Olsa)
Date: Sun, 28 Aug 2016 16:16:16 +0200
Subject: [PATCH V6 5/5] perf tools: adding sink configuration for cs_etm
 PMU
In-Reply-To: <1472156445-24283-6-git-send-email-mathieu.poirier@linaro.org>
References: <1472156445-24283-1-git-send-email-mathieu.poirier@linaro.org>
 <1472156445-24283-6-git-send-email-mathieu.poirier@linaro.org>
Message-ID: <20160828141616.GB32293@krava>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Thu, Aug 25, 2016 at 02:20:45PM -0600, Mathieu Poirier wrote:

SNIP

>  	return NULL;
>  }
> +
> +static FILE *cs_device__open_file(const char *name)
> +{
> +	struct stat st;
> +	char path[PATH_MAX];
> +	const char *sysfs;
> +
> +	sysfs = sysfs__mountpoint();
> +	if (!sysfs)
> +		return NULL;
> +
> +	snprintf(path, PATH_MAX,
> +		 "%s" CS_BUS_DEVICE_PATH "%s", sysfs, name);
> +
> +	printf("path: %s\n", path);

should this be pr_info ?

jirka

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755588AbcH1OQW (ORCPT <rfc822;w@1wt.eu>);
        Sun, 28 Aug 2016 10:16:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33276 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752371AbcH1OQU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 28 Aug 2016 10:16:20 -0400
Date: Sun, 28 Aug 2016 16:16:16 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V6 5/5] perf tools: adding sink configuration for cs_etm
 PMU
Message-ID: <20160828141616.GB32293@krava>
References: <1472156445-24283-1-git-send-email-mathieu.poirier@linaro.org>
 <1472156445-24283-6-git-send-email-mathieu.poirier@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1472156445-24283-6-git-send-email-mathieu.poirier@linaro.org>
User-Agent: Mutt/1.7.0 (2016-08-17)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sun, 28 Aug 2016 14:16:19 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 25, 2016 at 02:20:45PM -0600, Mathieu Poirier wrote:

SNIP

>  	return NULL;
>  }
> +
> +static FILE *cs_device__open_file(const char *name)
> +{
> +	struct stat st;
> +	char path[PATH_MAX];
> +	const char *sysfs;
> +
> +	sysfs = sysfs__mountpoint();
> +	if (!sysfs)
> +		return NULL;
> +
> +	snprintf(path, PATH_MAX,
> +		 "%s" CS_BUS_DEVICE_PATH "%s", sysfs, name);
> +
> +	printf("path: %s\n", path);

should this be pr_info ?

jirka