From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id E8DFB89F for ; Mon, 29 Aug 2016 08:20:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 8E67DE2 for ; Mon, 29 Aug 2016 08:20:19 +0000 (UTC) Date: Mon, 29 Aug 2016 01:20:15 -0700 From: Christoph Hellwig To: "Levin, Alexander" Message-ID: <20160829082015.GA16643@infradead.org> References: <1472330452.26978.23.camel@perches.com> <20160828005636.GB19088@sasha-lappy> <1472348579.26978.47.camel@perches.com> <20160828023807.GC19088@sasha-lappy> <1472404557.26978.84.camel@perches.com> <20160828223759.GA12993@sasha-lappy> <1472426452.26978.151.camel@perches.com> <20160829021055.GA24216@sasha-lappy> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160829021055.GA24216@sasha-lappy> Cc: Joe Perches , Greg KH , Sasha Levin , "ksummit-discuss@lists.linuxfoundation.org" , LKML Subject: Re: [Ksummit-discuss] checkkpatch (in)sanity ? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Seriously folks, checkpatch is a tool that's to be used for a reason, not a reason by itself. And it used to be a lot more useful before adding all kinds of bullshit warnings. I use checkpatch a lot, and I also ignore silly warnings in it a lot as it's piling up more and more crap. And then again there are just plenty of commits that touch existing code for a minor change, and I'm not going to bother rewriting the steaming pile of crap around it. And checkpath really shouldn't even bother to warn for context of diffs that's not even touched by default. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756800AbcH2IUV (ORCPT ); Mon, 29 Aug 2016 04:20:21 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:44672 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756125AbcH2IUT (ORCPT ); Mon, 29 Aug 2016 04:20:19 -0400 Date: Mon, 29 Aug 2016 01:20:15 -0700 From: Christoph Hellwig To: "Levin, Alexander" Cc: Joe Perches , Sasha Levin , Greg KH , LKML , "ksummit-discuss@lists.linuxfoundation.org" Subject: Re: checkkpatch (in)sanity ? Message-ID: <20160829082015.GA16643@infradead.org> References: <1472330452.26978.23.camel@perches.com> <20160828005636.GB19088@sasha-lappy> <1472348579.26978.47.camel@perches.com> <20160828023807.GC19088@sasha-lappy> <1472404557.26978.84.camel@perches.com> <20160828223759.GA12993@sasha-lappy> <1472426452.26978.151.camel@perches.com> <20160829021055.GA24216@sasha-lappy> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160829021055.GA24216@sasha-lappy> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Seriously folks, checkpatch is a tool that's to be used for a reason, not a reason by itself. And it used to be a lot more useful before adding all kinds of bullshit warnings. I use checkpatch a lot, and I also ignore silly warnings in it a lot as it's piling up more and more crap. And then again there are just plenty of commits that touch existing code for a minor change, and I'm not going to bother rewriting the steaming pile of crap around it. And checkpath really shouldn't even bother to warn for context of diffs that's not even touched by default.