All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] bus: mvebu-mbus: Provide stub function for mvebu_mbus_get_io_win_info()
Date: Mon, 29 Aug 2016 14:57:53 +0200	[thread overview]
Message-ID: <20160829125753.GC12465@lunn.ch> (raw)
In-Reply-To: <20160829110456.12206-1-sr@denx.de>

On Mon, Aug 29, 2016 at 01:04:55PM +0200, Stefan Roese wrote:
> This patch provides a stub function for mvebu_mbus_get_io_win_info(),
> which will be used for all non-Orion (ARM32 MVEBU) platforms for
> compile test coverage.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Marcin Wojtas <mw@semihalf.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Vinod Koul <vinod.koul@intel.com>
> ---
>  include/linux/mbus.h | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/mbus.h b/include/linux/mbus.h
> index d610232..a884405 100644
> --- a/include/linux/mbus.h
> +++ b/include/linux/mbus.h
> @@ -55,6 +55,8 @@ struct mbus_dram_target_info
>  #ifdef CONFIG_PLAT_ORION
>  extern const struct mbus_dram_target_info *mv_mbus_dram_info(void);
>  extern const struct mbus_dram_target_info *mv_mbus_dram_info_nooverlap(void);
> +int mvebu_mbus_get_io_win_info(phys_addr_t phyaddr, u32 *size, u8 *target,
> +			       u8 *attr);
>  #else
>  static inline const struct mbus_dram_target_info *mv_mbus_dram_info(void)
>  {
> @@ -64,14 +66,17 @@ static inline const struct mbus_dram_target_info *mv_mbus_dram_info_nooverlap(vo
>  {
>  	return NULL;
>  }
> +static inline int mvebu_mbus_get_io_win_info(phys_addr_t phyaddr, u32 *size,
> +					     u8 *target, u8 *attr)
> +{
> +	return 0;
> +}
>  #endif

Hi Stefan

If i understand it correctly, this should never be used for real, it
is here only for compile testing?

Maybe add a WARN_ON_ONCE(1) here? And a comment, why it should never
happen.

Thanks

      Andrew

  parent reply	other threads:[~2016-08-29 12:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-29 11:04 [PATCH 1/2] bus: mvebu-mbus: Provide stub function for mvebu_mbus_get_io_win_info() Stefan Roese
2016-08-29 11:04 ` [PATCH 2/2 v3] dmaengine: mv_xor: Add support for IO (PCIe) src/dst areas Stefan Roese
2016-08-29 12:57 ` Andrew Lunn [this message]
2016-08-29 13:54   ` [PATCH 1/2] bus: mvebu-mbus: Provide stub function for mvebu_mbus_get_io_win_info() Stefan Roese
2016-08-29 14:02   ` Gregory CLEMENT
2016-08-29 14:57     ` Andrew Lunn
2016-08-29 17:40     ` Stefan Roese
2016-08-31 15:23       ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160829125753.GC12465@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.