All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: sean.wang@mediatek.com
Cc: john@phrozen.org, davem@davemloft.net, nbd@openwrt.org,
	netdev@vger.kernel.org, linux-mediatek@lists.infradead.org,
	keyhaede@gmail.com
Subject: Re: [PATCH net v2 8/9] net: ethernet: mediatek: use devm_mdiobus_alloc instead of mdiobus_alloc inside mtk_mdio_init
Date: Mon, 29 Aug 2016 15:06:28 +0200	[thread overview]
Message-ID: <20160829130628.GD12465@lunn.ch> (raw)
In-Reply-To: <1472447003-30726-9-git-send-email-sean.wang@mediatek.com>

On Mon, Aug 29, 2016 at 01:03:22PM +0800, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
> 
> a lot of parts in the driver uses devm_* APIs to gain benefits from the
> device resource management, so devm_mdiobus_alloc is also used instead
> of mdiobus_alloc to have more elegant code flow.
> 
> Using common code provided by the devm_* helps to
> 1) have simplified the code flow as [1] says
> 2) decrease the risk of incorrect error handling by human
> 3) only a few drivers used it since it ware proposed on linux 3.16,
> so just hope to promote for this.
> 
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> 
> ---
> ref.
> [1] https://patchwork.ozlabs.org/patch/344093/
> ---

Hi Sean

Your footnote is below the ---, so won't make it into the change log. 

Apart from that,

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

  reply	other threads:[~2016-08-29 13:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-29  5:03 [PATCH net v2 0/9] net: ethernet: mediatek: a couple of fixes sean.wang-NuS5LvNUpcJWk0Htik3J/w
2016-08-29  5:03 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w
     [not found] ` <1472447003-30726-1-git-send-email-sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2016-08-29  5:03   ` [PATCH net v2 1/9] net: ethernet: mediatek: fix fails from TX housekeeping due to incorrect port setup sean.wang-NuS5LvNUpcJWk0Htik3J/w
2016-08-29  5:03     ` sean.wang-NuS5LvNUpcJWk0Htik3J/w
2016-08-29  5:03   ` [PATCH net v2 2/9] net: ethernet: mediatek: fix incorrect return value of devm_clk_get with EPROBE_DEFER sean.wang-NuS5LvNUpcJWk0Htik3J/w
2016-08-29  5:03     ` sean.wang-NuS5LvNUpcJWk0Htik3J/w
2016-08-29  5:03   ` [PATCH net v2 4/9] net: ethernet: mediatek: remove redundant free_irq for devm_request_irq allocated irq sean.wang-NuS5LvNUpcJWk0Htik3J/w
2016-08-29  5:03     ` sean.wang-NuS5LvNUpcJWk0Htik3J/w
2016-08-29  5:03   ` [PATCH net v2 5/9] net: ethernet: mediatek: fix logic unbalance between probe and remove sean.wang-NuS5LvNUpcJWk0Htik3J/w
2016-08-29  5:03     ` sean.wang-NuS5LvNUpcJWk0Htik3J/w
2016-08-29  5:03   ` [PATCH net v2 6/9] net: ethernet: mediatek: fix issue of driver removal with interface is up sean.wang-NuS5LvNUpcJWk0Htik3J/w
2016-08-29  5:03     ` sean.wang-NuS5LvNUpcJWk0Htik3J/w
2016-08-29  5:03 ` [PATCH net v2 3/9] net: ethernet: mediatek: fix API usage with skb_free_frag sean.wang
2016-08-29  5:03   ` sean.wang
2016-08-29  5:03 ` [PATCH net v2 7/9] net: ethernet: mediatek: fix the missing of_node_put() after node is used done inside mtk_mdio_init sean.wang
2016-08-29  5:03   ` sean.wang
2016-08-29  5:03 ` [PATCH net v2 8/9] net: ethernet: mediatek: use devm_mdiobus_alloc instead of mdiobus_alloc " sean.wang
2016-08-29  5:03   ` sean.wang
2016-08-29 13:06   ` Andrew Lunn [this message]
2016-08-29  5:03 ` [PATCH net v2 9/9] net: ethernet: mediatek: fix error handling " sean.wang
2016-08-29  5:03   ` sean.wang
2016-08-29 13:15   ` Andrew Lunn
2016-08-29 16:10     ` Sean Wang
2016-08-29 16:10       ` Sean Wang
2016-08-29 16:36   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160829130628.GD12465@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=john@phrozen.org \
    --cc=keyhaede@gmail.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=nbd@openwrt.org \
    --cc=netdev@vger.kernel.org \
    --cc=sean.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.