From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 2/4 v2] soc: qcom: add EBI2 driver
Date: Mon, 29 Aug 2016 15:20:07 +0200
Message-ID: <201608291520.07798.arnd@arndb.de>
References: <1472028758-29272-1-git-send-email-linus.walleij@linaro.org>
 <1472028758-29272-3-git-send-email-linus.walleij@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org>
In-Reply-To: <1472028758-29272-3-git-send-email-linus.walleij@linaro.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>,
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org
To: linux-arm-kernel@lists.infradead.org
Cc: linux-arm-msm@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, Stephen Boyd <sboyd@codeaurora.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, David Brown <david.brown@linaro.org>, Andy Gross <andy.gross@linaro.org>, linux-soc@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org

On Wednesday 24 August 2016, Linus Walleij wrote:

> +static void qcom_ebi2_setup_chipselect(struct device_node *np,
> +				       struct device *dev,
> +				       void __iomem *ebi2_base,
> +				       void __iomem *ebi2_xmem,
> +				       u32 csindex)
> +{
> +	const struct cs_data *csd;
> +	u32 slowcfg, fastcfg;
> +	u32 val;
> +	int ret;
> +	int i;
> +
> +	csd = &cs_info[csindex];
> +	val = readl_relaxed(ebi2_base);
> +	val |= csd->enable_mask;
> +	writel_relaxed(val, ebi2_base);
> +	dev_dbg(dev, "enabled CS%u\n", csindex);

better use readl/writel instead of *_relaxed() if it's not performance critical.
If you have a function that is worth optimizing with relaxed accessors, add a
comment about how your concluded that it's safe to do so.

> +static struct platform_driver qcom_ebi2_driver = {
> +	.probe = qcom_ebi2_probe,
> +	.driver = {
> +		.name = "qcom-ebi2",
> +		.of_match_table = qcom_ebi2_of_match,
> +	},
> +};
> +builtin_platform_driver(qcom_ebi2_driver);

Why not allow this to be a loadable module?

	Arnd

From mboxrd@z Thu Jan  1 00:00:00 1970
From: arnd@arndb.de (Arnd Bergmann)
Date: Mon, 29 Aug 2016 15:20:07 +0200
Subject: [PATCH 2/4 v2] soc: qcom: add EBI2 driver
In-Reply-To: <1472028758-29272-3-git-send-email-linus.walleij@linaro.org>
References: <1472028758-29272-1-git-send-email-linus.walleij@linaro.org>
 <1472028758-29272-3-git-send-email-linus.walleij@linaro.org>
Message-ID: <201608291520.07798.arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Wednesday 24 August 2016, Linus Walleij wrote:

> +static void qcom_ebi2_setup_chipselect(struct device_node *np,
> +				       struct device *dev,
> +				       void __iomem *ebi2_base,
> +				       void __iomem *ebi2_xmem,
> +				       u32 csindex)
> +{
> +	const struct cs_data *csd;
> +	u32 slowcfg, fastcfg;
> +	u32 val;
> +	int ret;
> +	int i;
> +
> +	csd = &cs_info[csindex];
> +	val = readl_relaxed(ebi2_base);
> +	val |= csd->enable_mask;
> +	writel_relaxed(val, ebi2_base);
> +	dev_dbg(dev, "enabled CS%u\n", csindex);

better use readl/writel instead of *_relaxed() if it's not performance critical.
If you have a function that is worth optimizing with relaxed accessors, add a
comment about how your concluded that it's safe to do so.

> +static struct platform_driver qcom_ebi2_driver = {
> +	.probe = qcom_ebi2_probe,
> +	.driver = {
> +		.name = "qcom-ebi2",
> +		.of_match_table = qcom_ebi2_of_match,
> +	},
> +};
> +builtin_platform_driver(qcom_ebi2_driver);

Why not allow this to be a loadable module?

	Arnd