From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 2/4 v2] soc: qcom: add EBI2 driver
Date: Mon, 29 Aug 2016 15:36:34 +0200
Message-ID: <201608291536.34501.arnd@arndb.de>
References: <1472028758-29272-1-git-send-email-linus.walleij@linaro.org> <201608291520.07798.arnd@arndb.de> <CACRpkdZHHGZaaxym9f-3mGREmokRhgNm3yb_HxaP0=_iuZNk1g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from mout.kundenserver.de ([217.72.192.73]:56746 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933477AbcH2NhG (ORCPT
        <rfc822;linux-arm-msm@vger.kernel.org>);
        Mon, 29 Aug 2016 09:37:06 -0400
In-Reply-To: <CACRpkdZHHGZaaxym9f-3mGREmokRhgNm3yb_HxaP0=_iuZNk1g@mail.gmail.com>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>, linux-soc@vger.kernel.org, Andy Gross <andy.gross@linaro.org>, David Brown <david.brown@linaro.org>, Stephen Boyd <sboyd@codeaurora.org>, Bjorn Andersson <bjorn.andersson@linaro.org>

On Monday 29 August 2016, Linus Walleij wrote:
> >> +static struct platform_driver qcom_ebi2_driver = {
> >> +     .probe = qcom_ebi2_probe,
> >> +     .driver = {
> >> +             .name = "qcom-ebi2",
> >> +             .of_match_table = qcom_ebi2_of_match,
> >> +     },
> >> +};
> >> +builtin_platform_driver(qcom_ebi2_driver);
> >
> > Why not allow this to be a loadable module?
> 
> I don't see any point in it, it's so basic to be able to access the
> MMIO devices on the platform, the plan was to select the driver
> from the corresponding mach-qcom SoC type (MSM8660+APQ8060).
> 
> But I can make it a module instead, if preferred.

Ok, I expected this to be only for rare optional devices such as
NOR flash or the ethernet device from your example. If this is required
for booting a system, making it a module won't help much.

	Arnd

From mboxrd@z Thu Jan  1 00:00:00 1970
From: arnd@arndb.de (Arnd Bergmann)
Date: Mon, 29 Aug 2016 15:36:34 +0200
Subject: [PATCH 2/4 v2] soc: qcom: add EBI2 driver
In-Reply-To: <CACRpkdZHHGZaaxym9f-3mGREmokRhgNm3yb_HxaP0=_iuZNk1g@mail.gmail.com>
References: <1472028758-29272-1-git-send-email-linus.walleij@linaro.org>
 <201608291520.07798.arnd@arndb.de>
 <CACRpkdZHHGZaaxym9f-3mGREmokRhgNm3yb_HxaP0=_iuZNk1g@mail.gmail.com>
Message-ID: <201608291536.34501.arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Monday 29 August 2016, Linus Walleij wrote:
> >> +static struct platform_driver qcom_ebi2_driver = {
> >> +     .probe = qcom_ebi2_probe,
> >> +     .driver = {
> >> +             .name = "qcom-ebi2",
> >> +             .of_match_table = qcom_ebi2_of_match,
> >> +     },
> >> +};
> >> +builtin_platform_driver(qcom_ebi2_driver);
> >
> > Why not allow this to be a loadable module?
> 
> I don't see any point in it, it's so basic to be able to access the
> MMIO devices on the platform, the plan was to select the driver
> from the corresponding mach-qcom SoC type (MSM8660+APQ8060).
> 
> But I can make it a module instead, if preferred.

Ok, I expected this to be only for rare optional devices such as
NOR flash or the ethernet device from your example. If this is required
for booting a system, making it a module won't help much.

	Arnd