All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
	linux-clk@vger.kernel.org, Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH 3/3 v3] clk: versatile/icst: support for AP baseboard clocks
Date: Mon, 29 Aug 2016 10:49:40 -0700	[thread overview]
Message-ID: <20160829174940.GC19826@codeaurora.org> (raw)
In-Reply-To: <1472299279-27560-1-git-send-email-linus.walleij@linaro.org>

On 08/27, Linus Walleij wrote:
> @@ -143,6 +180,16 @@ static int vco_set(struct clk_icst *icst, struct icst_vco vco)
>  		if (vco.r != 22)
>  			pr_err("ICST error: tried to use RDW != 22\n");
>  		break;
> +	case ICST_INTEGRATOR_AP_SYS:
> +		mask = INTEGRATOR_AP_SYS_BITS;
> +		val |= vco.v & 0xFF;

drivers/clk/versatile/clk-icst.c: In function ‘icst_set_rate’:
drivers/clk/versatile/clk-icst.c:185:7: warning: ‘val’ may be used uninitialized in this function [-Wuninitialized]
drivers/clk/versatile/clk-icst.c:168:6: note: ‘val’ was declared here


I assume it should just be val = instead?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2016-08-29 17:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-27 12:01 [PATCH 3/3 v3] clk: versatile/icst: support for AP baseboard clocks Linus Walleij
2016-08-29 17:49 ` Stephen Boyd [this message]
2016-08-29 18:33   ` Linus Walleij
2016-08-29 18:38     ` Stephen Boyd
2016-08-29 18:39       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160829174940.GC19826@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mturquette@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.