From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH] arm64: KVM: Save two instructions in __guest_enter() Date: Mon, 29 Aug 2016 20:15:09 +0200 Message-ID: <20160829181509.GC10162@cbox> References: <1470791736-13949-1-git-send-email-shankerd@codeaurora.org> <20160825133122.GA8016@lvm> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A2FB14998D for ; Mon, 29 Aug 2016 14:04:51 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uWGZ+KxvJwDJ for ; Mon, 29 Aug 2016 14:04:50 -0400 (EDT) Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 8D12940FA2 for ; Mon, 29 Aug 2016 14:04:50 -0400 (EDT) Received: by mail-wm0-f54.google.com with SMTP id i5so105063621wmg.0 for ; Mon, 29 Aug 2016 11:12:53 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Shanker Donthineni Cc: Marc Zyngier , Catalin Marinas , Will Deacon , linux-kernel , Paolo Bonzini , kvmarm , linux-arm-kernel List-Id: kvmarm@lists.cs.columbia.edu On Mon, Aug 29, 2016 at 10:22:06AM -0500, Shanker Donthineni wrote: > Hi Christoffer, > > This is change may not provide the measurable performance > improvement, but still we can > save a few cpu cycles on vCPU context switch and also improves the > code readability. I'm not so convinced about saving CPU cycles, but now when I've reviewed your patch I think it has potential to slightly improve the code. See my review of your patch. -Christoffer From mboxrd@z Thu Jan 1 00:00:00 1970 From: christoffer.dall@linaro.org (Christoffer Dall) Date: Mon, 29 Aug 2016 20:15:09 +0200 Subject: [PATCH] arm64: KVM: Save two instructions in __guest_enter() In-Reply-To: References: <1470791736-13949-1-git-send-email-shankerd@codeaurora.org> <20160825133122.GA8016@lvm> Message-ID: <20160829181509.GC10162@cbox> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Aug 29, 2016 at 10:22:06AM -0500, Shanker Donthineni wrote: > Hi Christoffer, > > This is change may not provide the measurable performance > improvement, but still we can > save a few cpu cycles on vCPU context switch and also improves the > code readability. I'm not so convinced about saving CPU cycles, but now when I've reviewed your patch I think it has potential to slightly improve the code. See my review of your patch. -Christoffer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756135AbcH2SMz (ORCPT ); Mon, 29 Aug 2016 14:12:55 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:35807 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772AbcH2SMx (ORCPT ); Mon, 29 Aug 2016 14:12:53 -0400 Date: Mon, 29 Aug 2016 20:15:09 +0200 From: Christoffer Dall To: Shanker Donthineni Cc: Marc Zyngier , linux-kernel , linux-arm-kernel , kvmarm , Paolo Bonzini , Will Deacon , Catalin Marinas , James Morse Subject: Re: [PATCH] arm64: KVM: Save two instructions in __guest_enter() Message-ID: <20160829181509.GC10162@cbox> References: <1470791736-13949-1-git-send-email-shankerd@codeaurora.org> <20160825133122.GA8016@lvm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 29, 2016 at 10:22:06AM -0500, Shanker Donthineni wrote: > Hi Christoffer, > > This is change may not provide the measurable performance > improvement, but still we can > save a few cpu cycles on vCPU context switch and also improves the > code readability. I'm not so convinced about saving CPU cycles, but now when I've reviewed your patch I think it has potential to slightly improve the code. See my review of your patch. -Christoffer