From: "Bill O'Donnell" <billodo@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprogs: don't populate fs table with foreign fs paths unless foreign_allowed
Date: Mon, 29 Aug 2016 18:26:15 -0500 [thread overview]
Message-ID: <20160829232615.GA29648@redhat.com> (raw)
In-Reply-To: <20160829231205.GO19025@dastard>
On Tue, Aug 30, 2016 at 09:12:06AM +1000, Dave Chinner wrote:
> On Mon, Aug 29, 2016 at 08:40:12AM -0500, Bill O'Donnell wrote:
> > Commits b20b6c2 and 29647c8 modified xfs_quota for use on
> > non-XFS filesystems. One modification in fs_initialise_mounts
> > (paths.c) resulted in an xfstest fail (xfs/261), due to foreign
> > fs paths entering the fs table.
>
> What's the failure? I'm not seeing it here on any of my test
> machines...
On my box, there are a few ext4 mounts, and test xfs/261
populates the fs table with those paths. So when xfs_quota commands
in 261 are executed, a "foreign filesystem" message is thrown.
My first notion was to add a -f to the xfs_quota command in 261,
but then I decided it was better to change the xfsprogs code back
to the old behavior.
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-08-29 23:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 13:40 [PATCH] xfsprogs: don't populate fs table with foreign fs paths unless foreign_allowed Bill O'Donnell
2016-08-29 15:13 ` Darrick J. Wong
2016-08-29 15:43 ` Bill O'Donnell
2016-08-29 23:16 ` Dave Chinner
2016-08-29 23:28 ` Bill O'Donnell
2016-08-29 23:12 ` Dave Chinner
2016-08-29 23:26 ` Bill O'Donnell [this message]
2016-08-29 23:40 ` Dave Chinner
2016-08-29 23:47 ` Bill O'Donnell
2016-08-30 0:25 ` Dave Chinner
2016-08-30 0:53 ` Bill O'Donnell
2016-09-01 22:07 ` Bill O'Donnell
2016-09-02 21:22 ` [PATCH v2] xfsprogs: (xfs_quota) foreign fs path handling changes Bill O'Donnell
2016-09-02 22:57 ` Eric Sandeen
2016-09-02 23:10 ` Bill O'Donnell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829232615.GA29648@redhat.com \
--to=billodo@redhat.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.