From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PATCH v2 0/2] vfio: blacklist legacy virtio devices Date: Tue, 30 Aug 2016 06:49:51 +0300 Message-ID: <20160830064857-mutt-send-email-mst@kernel.org> References: <1472523968-9540-1-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Jason Wang Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org T24gVHVlLCBBdWcgMzAsIDIwMTYgYXQgMTE6MTY6MjVBTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiAKPiBPbiAyMDE25bm0MDjmnIgzMOaXpSAxMDoyNywgTWljaGFlbCBTLiBUc2lya2lu IHdyb3RlOgo+ID4gTGVnYWN5IHZpcnRpbyBkZXZpY2VzIGFsd2F5cyBieXBhc3NlZCBhbiBJT01N VSwgc28gdXNpbmcgdGhlbSB3aXRoIHZmaW8gd2FzCj4gPiBuZXZlciBzYWZlLgo+IAo+IEFuZCBp dCBhY3R1YWxseSB3b24ndCB3b3JrIHNpbmNlIEdQQSBpcyBhc3N1bWVkIGluIHRoZSBkZXZpY2Uu IFNvIEknbSBub3QKPiBzdXJlIHRoaXMgaXMgbXVzdCBzaW5jZSB3ZSBzaG91bGQgZ2V0IGEgSU9N TVUgZmF1bHQgaW4gdGhpcyBjYXNlLgoKV2Ugd29uJ3QgZ2V0IGFuIElPTU1VIGZhdWx0IGZvciBs ZWdhY3kgc3lzdGVtcyBzaW5jZSB0aGV5CmJ5cGFzcyB0aGUgSU9NTVUuIEluc3RlYWQgZ3Vlc3Qg dXNlcnNwYWNlIHdpbGwgZ2V0IGZ1bGwKYWNjZXNzIHRvIGFsbCBvZiBndWVzdCBtZW1vcnkgdGhy b3VnaCB0aGUgZGV2aWNlLgoKCj4gPiAgIFRoaXMgYWRkcyBhIHF1aXJrIGRldGVjdGluZyB0aGVz ZSBhbmQgZGlzYWJsaW5nIFZGSU8gdW5sZXNzIHRoZQo+ID4gbm9pb21tdSBtb2RlIGlzIHVzZWQu ICBBdCB0aGUgbW9tZW50LCB0aGlzIG9ubHkgYXBwbGllcyB0byB2aXJ0aW8tcGNpIGRldmljZXMu Cj4gPiAKPiA+IFRoZSBwYXRjaCBtaWdodCBtYWtlIHNlbnNlIG9uIHN0YWJsZSBhcyB3ZWxsLgo+ ID4gCj4gPiBNaWNoYWVsIFMuIFRzaXJraW4gKDIpOgo+ID4gICAgdmZpbzogcmVwb3J0IGdyb3Vw IG5vaW9tbXUgc3RhdHVzCj4gPiAgICB2ZmlvOiBhZGQgdmlydGlvIHBjaSBxdWlyawo+ID4gCj4g PiAgIGRyaXZlcnMvdmZpby9wY2kvdmZpb19wY2lfcHJpdmF0ZS5oIHwgICAxICsKPiA+ICAgaW5j bHVkZS9saW51eC92ZmlvLmggICAgICAgICAgICAgICAgfCAgIDIgKwo+ID4gICBkcml2ZXJzL3Zm aW8vcGNpL3ZmaW9fcGNpLmMgICAgICAgICB8ICAxNCArKysrCj4gPiAgIGRyaXZlcnMvdmZpby9w Y2kvdmZpb19wY2lfdmlydGlvLmMgIHwgMTQwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKwo+ID4gICBkcml2ZXJzL3ZmaW8vdmZpby5jICAgICAgICAgICAgICAgICB8ICAxMiAr KysrCj4gPiAgIGRyaXZlcnMvdmZpby9wY2kvTWFrZWZpbGUgICAgICAgICAgIHwgICAxICsKPiA+ ICAgNiBmaWxlcyBjaGFuZ2VkLCAxNzAgaW5zZXJ0aW9ucygrKQo+ID4gICBjcmVhdGUgbW9kZSAx MDA2NDQgZHJpdmVycy92ZmlvL3BjaS92ZmlvX3BjaV92aXJ0aW8uYwo+ID4gCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxp bmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczov L2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlv bg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757414AbcH3Dty (ORCPT ); Mon, 29 Aug 2016 23:49:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53588 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757185AbcH3Dtx (ORCPT ); Mon, 29 Aug 2016 23:49:53 -0400 Date: Tue, 30 Aug 2016 06:49:51 +0300 From: "Michael S. Tsirkin" To: Jason Wang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Alex Williamson , Cornelia Huck Subject: Re: [Qemu-devel] [PATCH v2 0/2] vfio: blacklist legacy virtio devices Message-ID: <20160830064857-mutt-send-email-mst@kernel.org> References: <1472523968-9540-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 30 Aug 2016 03:49:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2016 at 11:16:25AM +0800, Jason Wang wrote: > > > On 2016年08月30日 10:27, Michael S. Tsirkin wrote: > > Legacy virtio devices always bypassed an IOMMU, so using them with vfio was > > never safe. > > And it actually won't work since GPA is assumed in the device. So I'm not > sure this is must since we should get a IOMMU fault in this case. We won't get an IOMMU fault for legacy systems since they bypass the IOMMU. Instead guest userspace will get full access to all of guest memory through the device. > > This adds a quirk detecting these and disabling VFIO unless the > > noiommu mode is used. At the moment, this only applies to virtio-pci devices. > > > > The patch might make sense on stable as well. > > > > Michael S. Tsirkin (2): > > vfio: report group noiommu status > > vfio: add virtio pci quirk > > > > drivers/vfio/pci/vfio_pci_private.h | 1 + > > include/linux/vfio.h | 2 + > > drivers/vfio/pci/vfio_pci.c | 14 ++++ > > drivers/vfio/pci/vfio_pci_virtio.c | 140 ++++++++++++++++++++++++++++++++++++ > > drivers/vfio/vfio.c | 12 ++++ > > drivers/vfio/pci/Makefile | 1 + > > 6 files changed, 170 insertions(+) > > create mode 100644 drivers/vfio/pci/vfio_pci_virtio.c > >