diff for duplicates of <20160830120220.GC8363@tiger> diff --git a/a/1.txt b/N1/1.txt index 8d52835..7c5a438 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,33 +2,33 @@ On Mon, Aug 29, 2016 at 12:51:01PM -0500, Scott Wood wrote: > On Mon, 2016-08-29 at 17:52 +0800, Shawn Guo wrote: > > On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote: > > > -> > > + clockgen: clocking at 1ee1000 { +> > > + clockgen: clocking@1ee1000 { > > > + compatible = "fsl,ls1012a-clockgen"; > > The compatible cannot be found in binding docs. > -> From?Documentation/devicetree/bindings/clock/qoriq-clock.txt: +> From Documentation/devicetree/bindings/clock/qoriq-clock.txt: > > - compatible: Should contain a chip-specific clock block compatible -> ????????string and (if applicable) may contain a chassis-version clock -> ????????compatible string. +> string and (if applicable) may contain a chassis-version clock +> compatible string. > -> ? ? ? ? Chip-specific strings are of the form "fsl,<chip>-clockgen", such as: -> ????????* "fsl,p2041-clockgen" -> ????????* "fsl,p3041-clockgen" -> ????????* "fsl,p4080-clockgen" -> ????????* "fsl,p5020-clockgen" -> ????????* "fsl,p5040-clockgen" -> ????????* "fsl,t4240-clockgen" -> ????????* "fsl,b4420-clockgen" -> ????????* "fsl,b4860-clockgen" -> ????????* "fsl,ls1021a-clockgen" -> ????????Chassis-version clock strings include: -> ????????* "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks -> ????????* "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks +> Chip-specific strings are of the form "fsl,<chip>-clockgen", such as: +> * "fsl,p2041-clockgen" +> * "fsl,p3041-clockgen" +> * "fsl,p4080-clockgen" +> * "fsl,p5020-clockgen" +> * "fsl,p5040-clockgen" +> * "fsl,t4240-clockgen" +> * "fsl,b4420-clockgen" +> * "fsl,b4860-clockgen" +> * "fsl,ls1021a-clockgen" +> Chassis-version clock strings include: +> * "fsl,qoriq-clockgen-1.0": for chassis 1.0 clocks +> * "fsl,qoriq-clockgen-2.0": for chassis 2.0 clocks > > I really hope we don't have to update every single fsl,<chip>-whatever binding -> every time a new chip comes out. ?There are already other chips not listed, -> FWIW (e.g. t1040, t2080, ls1043a, and ls2080a). ?That's why it says "such as". +> every time a new chip comes out. There are already other chips not listed, +> FWIW (e.g. t1040, t2080, ls1043a, and ls2080a). That's why it says "such as". If I remember correctly, DT maintainers want every supported compatible string explicitly listed in bindings doc. And they even added a check @@ -36,7 +36,7 @@ into checkpatch.pl with commit bff5da433525 ("checkpatch: add DT compatible string documentation checks"). > -> > > + scfg: scfg at 1570000 { +> > > + scfg: scfg@1570000 { > > > + compatible = "fsl,ls1012a-scfg", "syscon"; > > Ditto > > @@ -45,14 +45,14 @@ compatible string documentation checks"). > > > + big-endian; > > > + }; > > > + -> > > + dcfg: dcfg at 1ee0000 { +> > > + dcfg: dcfg@1ee0000 { > > > + compatible = "fsl,ls1012a-dcfg", -> > > + ?????"fsl,ls1043a-dcfg", -> > If these compatibles are not documented or used, we can drop them???I +> > > + "fsl,ls1043a-dcfg", +> > If these compatibles are not documented or used, we can drop them? I > > guess we only need "syscon" to get it work? > > If you only have "syscon" then how to do the users of the node properly know -> what register set they're dealing with? ?"syscon" should not be the only +> what register set they're dealing with? "syscon" should not be the only > compatible on a node. Okay, I assumed that a single user only need to deal with one particular @@ -61,7 +61,7 @@ that's not always the case. But at least, "fsl,ls1043a-dcfg" can be dropped here? > > > + -> > > + rcpm: rcpm at 1ee2000 { +> > > + rcpm: rcpm@1ee2000 { > > > + compatible = "fsl,ls1012a-rcpm"; > > Undocumented/unsupported bindings? > @@ -71,38 +71,38 @@ I failed to grep the string in both bindings and drivers folder, so thought this is an undocumented/unsupported compatible. > -> > > + tmu: tmu at 1f00000 { +> > > + tmu: tmu@1f00000 { > > > + compatible = "fsl,ls1012a-tmu", "fsl,qoriq-tmu"; > > > + reg = <0x0 0x1f00000 0x0 0x10000>; > > > + interrupts = <0 33 0x4>; > > > + fsl,tmu-range = <0xb0000 0x9002a 0x6004c > > > 0x30062>; > > > + fsl,tmu-calibration = <0x00000000 0x00000026 -> > > + ???????0x00000001 0x0000002d -> > > + ???????0x00000002 0x00000032 -> > > + ???????0x00000003 0x00000039 -> > > + ???????0x00000004 0x0000003f -> > > + ???????0x00000005 0x00000046 -> > > + ???????0x00000006 0x0000004d -> > > + ???????0x00000007 0x00000054 -> > > + ???????0x00000008 0x0000005a -> > > + ???????0x00000009 0x00000061 -> > > + ???????0x0000000a 0x0000006a -> > > + ???????0x0000000b 0x00000071 +> > > + 0x00000001 0x0000002d +> > > + 0x00000002 0x00000032 +> > > + 0x00000003 0x00000039 +> > > + 0x00000004 0x0000003f +> > > + 0x00000005 0x00000046 +> > > + 0x00000006 0x0000004d +> > > + 0x00000007 0x00000054 +> > > + 0x00000008 0x0000005a +> > > + 0x00000009 0x00000061 +> > > + 0x0000000a 0x0000006a +> > > + 0x0000000b 0x00000071 > > > + > > Drop the newline. > > > > > -> > > + ???????0x00010000 0x00000025 -> > > + ???????0x00010001 0x0000002c -> > > + ???????0x00010002 0x00000035 -> > > + ???????0x00010003 0x0000003d -> > > + ???????0x00010004 0x00000045 -> > > + ???????0x00010005 0x0000004e -> > > + ???????0x00010006 0x00000057 -> > > + ???????0x00010007 0x00000061 -> > > + ???????0x00010008 0x0000006b -> > > + ???????0x00010009 0x00000076 +> > > + 0x00010000 0x00000025 +> > > + 0x00010001 0x0000002c +> > > + 0x00010002 0x00000035 +> > > + 0x00010003 0x0000003d +> > > + 0x00010004 0x00000045 +> > > + 0x00010005 0x0000004e +> > > + 0x00010006 0x00000057 +> > > + 0x00010007 0x00000061 +> > > + 0x00010008 0x0000006b +> > > + 0x00010009 0x00000076 > > > + > > Ditto > @@ -113,3 +113,7 @@ Can we replace the newline with a single line comment to tell how they are grouped? Shawn +-- +To unsubscribe from this list: send the line "unsubscribe devicetree" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index a624f3b..fcc0fff 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,43 +1,51 @@ "ref\01472207241-18461-1-git-send-email-Bhaskar.Upadhaya@nxp.com\0" "ref\020160829095239.GM30790@tiger\0" "ref\01472493061.13245.39.camel@buserror.net\0" - "From\0shawnguo@kernel.org (Shawn Guo)\0" - "Subject\0[PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC\0" + "ref\01472493061.13245.39.camel-fOR+EgIDQEHk1uMJSBkQmQ@public.gmane.org\0" + "From\0Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>\0" + "Subject\0Re: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC\0" "Date\0Tue, 30 Aug 2016 20:02:20 +0800\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Scott Wood <oss-fOR+EgIDQEHk1uMJSBkQmQ@public.gmane.org>\0" + "Cc\0Bhaskar Upadhaya <Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>" + devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + Pratiyush Mohan Srivastava <pratiyush.srivastava-3arQi8VN3Tc@public.gmane.org> + stuart.yoder-3arQi8VN3Tc@public.gmane.org + Prabhakar Kushwaha <prabhakar.kushwaha-3arQi8VN3Tc@public.gmane.org> + linux-devel-XDVM779Km55Y1YpKYGMr2+TW4wlIGRCZ@public.gmane.org + " linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org\0" "\00:1\0" "b\0" "On Mon, Aug 29, 2016 at 12:51:01PM -0500, Scott Wood wrote:\n" "> On Mon, 2016-08-29 at 17:52 +0800, Shawn Guo wrote:\n" "> > On Fri, Aug 26, 2016 at 03:57:21PM +0530, Bhaskar Upadhaya wrote:\n" "> > > \n" - "> > > +\t\tclockgen: clocking at 1ee1000 {\n" + "> > > +\t\tclockgen: clocking@1ee1000 {\n" "> > > +\t\t\tcompatible = \"fsl,ls1012a-clockgen\";\n" "> > The compatible cannot be found in binding docs.\n" "> \n" - "> From?Documentation/devicetree/bindings/clock/qoriq-clock.txt:\n" + "> From\302\240Documentation/devicetree/bindings/clock/qoriq-clock.txt:\n" "> \n" "> - compatible: Should contain a chip-specific clock block compatible\n" - "> ????????string and (if applicable) may contain a chassis-version clock\n" - "> ????????compatible string.\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240string and (if applicable) may contain a chassis-version clock\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240compatible string.\n" "> \n" - "> ? ? ? ? Chip-specific strings are of the form \"fsl,<chip>-clockgen\", such as:\n" - "> ????????* \"fsl,p2041-clockgen\"\n" - "> ????????* \"fsl,p3041-clockgen\"\n" - "> ????????* \"fsl,p4080-clockgen\"\n" - "> ????????* \"fsl,p5020-clockgen\"\n" - "> ????????* \"fsl,p5040-clockgen\"\n" - "> ????????* \"fsl,t4240-clockgen\"\n" - "> ????????* \"fsl,b4420-clockgen\"\n" - "> ????????* \"fsl,b4860-clockgen\"\n" - "> ????????* \"fsl,ls1021a-clockgen\"\n" - "> ????????Chassis-version clock strings include:\n" - "> ????????* \"fsl,qoriq-clockgen-1.0\": for chassis 1.0 clocks\n" - "> ????????* \"fsl,qoriq-clockgen-2.0\": for chassis 2.0 clocks\n" + "> \302\240 \302\240 \302\240 \302\240 Chip-specific strings are of the form \"fsl,<chip>-clockgen\", such as:\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240* \"fsl,p2041-clockgen\"\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240* \"fsl,p3041-clockgen\"\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240* \"fsl,p4080-clockgen\"\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240* \"fsl,p5020-clockgen\"\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240* \"fsl,p5040-clockgen\"\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240* \"fsl,t4240-clockgen\"\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240* \"fsl,b4420-clockgen\"\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240* \"fsl,b4860-clockgen\"\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240* \"fsl,ls1021a-clockgen\"\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240Chassis-version clock strings include:\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240* \"fsl,qoriq-clockgen-1.0\": for chassis 1.0 clocks\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240* \"fsl,qoriq-clockgen-2.0\": for chassis 2.0 clocks\n" "> \n" "> I really hope we don't have to update every single fsl,<chip>-whatever binding\n" - "> every time a new chip comes out. ?There are already other chips not listed,\n" - "> FWIW (e.g. t1040, t2080, ls1043a, and ls2080a). ?That's why it says \"such as\".\n" + "> every time a new chip comes out. \302\240There are already other chips not listed,\n" + "> FWIW (e.g. t1040, t2080, ls1043a, and ls2080a). \302\240That's why it says \"such as\".\n" "\n" "If I remember correctly, DT maintainers want every supported compatible\n" "string explicitly listed in bindings doc. And they even added a check\n" @@ -45,7 +53,7 @@ "compatible string documentation checks\").\n" "\n" "> \n" - "> > > +\t\tscfg: scfg at 1570000 {\n" + "> > > +\t\tscfg: scfg@1570000 {\n" "> > > +\t\t\tcompatible = \"fsl,ls1012a-scfg\", \"syscon\";\n" "> > Ditto\n" "> > \n" @@ -54,14 +62,14 @@ "> > > +\t\t\tbig-endian;\n" "> > > +\t\t};\n" "> > > +\n" - "> > > +\t\tdcfg: dcfg at 1ee0000 {\n" + "> > > +\t\tdcfg: dcfg@1ee0000 {\n" "> > > +\t\t\tcompatible = \"fsl,ls1012a-dcfg\",\n" - "> > > +\t\t\t\t?????\"fsl,ls1043a-dcfg\",\n" - "> > If these compatibles are not documented or used, we can drop them???I\n" + "> > > +\t\t\t\t\302\240\302\240\302\240\302\240\302\240\"fsl,ls1043a-dcfg\",\n" + "> > If these compatibles are not documented or used, we can drop them?\302\240\302\240I\n" "> > guess we only need \"syscon\" to get it work?\n" "> \n" "> If you only have \"syscon\" then how to do the users of the node properly know\n" - "> what register set they're dealing with? ?\"syscon\" should not be the only\n" + "> what register set they're dealing with? \302\240\"syscon\" should not be the only\n" "> compatible on a node.\n" "\n" "Okay, I assumed that a single user only need to deal with one particular\n" @@ -70,7 +78,7 @@ "dropped here?\n" "\n" "> > > +\n" - "> > > +\t\trcpm: rcpm at 1ee2000 {\n" + "> > > +\t\trcpm: rcpm@1ee2000 {\n" "> > > +\t\t\tcompatible = \"fsl,ls1012a-rcpm\";\n" "> > Undocumented/unsupported bindings?\n" "> \n" @@ -80,38 +88,38 @@ "thought this is an undocumented/unsupported compatible.\n" "\n" "> \n" - "> > > +\t\ttmu: tmu at 1f00000 {\n" + "> > > +\t\ttmu: tmu@1f00000 {\n" "> > > +\t\t\tcompatible = \"fsl,ls1012a-tmu\", \"fsl,qoriq-tmu\";\n" "> > > +\t\t\treg = <0x0 0x1f00000 0x0 0x10000>;\n" "> > > +\t\t\tinterrupts = <0 33 0x4>;\n" "> > > +\t\t\tfsl,tmu-range = <0xb0000 0x9002a 0x6004c\n" "> > > 0x30062>;\n" "> > > +\t\t\tfsl,tmu-calibration = <0x00000000 0x00000026\n" - "> > > +\t\t\t\t\t???????0x00000001 0x0000002d\n" - "> > > +\t\t\t\t\t???????0x00000002 0x00000032\n" - "> > > +\t\t\t\t\t???????0x00000003 0x00000039\n" - "> > > +\t\t\t\t\t???????0x00000004 0x0000003f\n" - "> > > +\t\t\t\t\t???????0x00000005 0x00000046\n" - "> > > +\t\t\t\t\t???????0x00000006 0x0000004d\n" - "> > > +\t\t\t\t\t???????0x00000007 0x00000054\n" - "> > > +\t\t\t\t\t???????0x00000008 0x0000005a\n" - "> > > +\t\t\t\t\t???????0x00000009 0x00000061\n" - "> > > +\t\t\t\t\t???????0x0000000a 0x0000006a\n" - "> > > +\t\t\t\t\t???????0x0000000b 0x00000071\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00000001 0x0000002d\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00000002 0x00000032\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00000003 0x00000039\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00000004 0x0000003f\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00000005 0x00000046\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00000006 0x0000004d\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00000007 0x00000054\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00000008 0x0000005a\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00000009 0x00000061\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x0000000a 0x0000006a\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x0000000b 0x00000071\n" "> > > +\n" "> > Drop the newline.\n" "> > \n" "> > > \n" - "> > > +\t\t\t\t\t???????0x00010000 0x00000025\n" - "> > > +\t\t\t\t\t???????0x00010001 0x0000002c\n" - "> > > +\t\t\t\t\t???????0x00010002 0x00000035\n" - "> > > +\t\t\t\t\t???????0x00010003 0x0000003d\n" - "> > > +\t\t\t\t\t???????0x00010004 0x00000045\n" - "> > > +\t\t\t\t\t???????0x00010005 0x0000004e\n" - "> > > +\t\t\t\t\t???????0x00010006 0x00000057\n" - "> > > +\t\t\t\t\t???????0x00010007 0x00000061\n" - "> > > +\t\t\t\t\t???????0x00010008 0x0000006b\n" - "> > > +\t\t\t\t\t???????0x00010009 0x00000076\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00010000 0x00000025\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00010001 0x0000002c\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00010002 0x00000035\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00010003 0x0000003d\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00010004 0x00000045\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00010005 0x0000004e\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00010006 0x00000057\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00010007 0x00000061\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00010008 0x0000006b\n" + "> > > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x00010009 0x00000076\n" "> > > +\n" "> > Ditto\n" "> \n" @@ -121,6 +129,10 @@ "Can we replace the newline with a single line comment to tell how they\n" "are grouped?\n" "\n" - Shawn + "Shawn\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -36a62a4509c6392199a3df766845648581c91f40a7232ae5e9e8b4d9e865b823 +81048e3527b6c99acf89acb0111a43ef65cb3100abdbd55f475186197afc8836
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.