Re: [PATCH v2 1/2] tools: remove blktap2 related code and documentation

[Wei Liu <wei.liu2@citrix.com>]

On Tue, Aug 30, 2016 at 01:54:17PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH v2 1/2] tools: remove blktap2 related code and documentation"):
> > Blktap2 is effectively dead code for a few years.
> > 
> > Notable changes in this patch:
> > 
> > 0. Unhook blktap2 from build system
> > 1. Now libxl no longer supports TAP disk backend, appropriate assertions
> >    are added and some code paths now return ERROR_FAIL
> > 2. Tap is no longer a supported backend in doc
> > 3. Remove relevant entries in MAINTAINERS
> > 
> > A patch to actually remove blktap2 directory will come later.
> 
> The change to libxl seems OK to me, although:
> 
> > This version is tested: libxl bails when trying to set backend to tap.
> 
> What error message and error code do you get ?  If we're removing
> this, we should make sure that the error message makes sense.
> 

The error code is going to be ERROR_INVAL. The error message is going to
be:

Disk vdev=XXX, backend tap unsuitable because blktap not supported
no suitable backend for disk XXX

See libxl__device_disk_set_backend.

> All the rest is fine by me.  But we should wait a bit more to see if
> anyone objects IMO.
> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel