From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59792)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1beiyr-00014j-Bb
	for qemu-devel@nongnu.org; Tue, 30 Aug 2016 09:21:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1beiyl-0003p3-PI
	for qemu-devel@nongnu.org; Tue, 30 Aug 2016 09:21:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50122)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1beiyl-0003ox-Jv
	for qemu-devel@nongnu.org; Tue, 30 Aug 2016 09:21:27 -0400
Date: Tue, 30 Aug 2016 21:21:22 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20160830132122.GC13644@pxdev.xzpeter.org>
References: <1472526419-5900-1-git-send-email-jasowang@redhat.com>
	<1472526419-5900-8-git-send-email-jasowang@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1472526419-5900-8-git-send-email-jasowang@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for 2.8 07/11] virtio-pci: address space
 translation service (ATS) support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>
Cc: mst@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, cornelia.huck@de.ibm.com, wexu@redhat.com, vkaplans@redhat.com

On Tue, Aug 30, 2016 at 11:06:55AM +0800, Jason Wang wrote:

[...]

> +/* Type 2: Root Port ATS Capability Reporting Structure */
> +struct AcpiDmarRootPortATS {
> +    uint16_t type;
> +    uint16_t length;
> +    uint8_t flags;
> +    uint8_t reserved;
> +    uint16_t pci_segment;
> +    AcpiDmarDeviceScope scope[0];
> +} QEMU_PACKED;
> +typedef struct AcpiDmarRootPortATS AcpiDmarRootPortATS;
> +

Maybe better moved into patch 8 (next one)? Since it's not related to
virtio bits, but ACPI.

-- peterx