Re: [PATCH 3/4] xen: fix gcov compilation

[Wei Liu <wei.liu2@citrix.com>]

On Tue, Aug 30, 2016 at 01:57:06PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH 3/4] xen: fix gcov compilation"):
> > Currently enabling gcov in hypervisor won't build because although
> > 26c9d03d ("gcov: Adding support for coverage information") claimed that
> > %.init.o files were excluded from applying compilation options, it was
> > in fact not true.
> > 
> > Fix that by filtering out the options correctly. Due to the dependency
> > of stub.o in x86 EFI build can't be eliminated easily and we prefer a
> > generalised method going forward, we introduce nogov-y to explicitly
>                                                     ^
> > mark objects that don't need to build with gcov support.
> 
> And I'm afraid the second sentence there is not comprehensible.  It
> seesm to be "Due to X, Y" but I can't quite figure out which parts of
> the sentence are X and which are Y.
> 

Let's rewrite it as such:

Due to 1) the dependency of stub.o in x86 EFI build can't be eliminated
easily and 2) we prefer a generalised method going forward, we introduce
nogov-y to explicitly.

Is this clearer?

> I'm not unhappy with the approach in the Makefile, though.
> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel