From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2] drm/nouveau/gr: mark gm107_grctx_generate_tpcid() static Date: Tue, 30 Aug 2016 14:40:52 +0200 Message-ID: <201608301440.52481.arnd@arndb.de> References: <1472475747-30296-1-git-send-email-baoyou.xie@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Baoyou Xie Cc: Sean Paul , nouveau@lists.freedesktop.org, xie.baoyou@zte.com.cn, Linux Kernel Mailing List , dri-devel , bskeggs@redhat.com List-Id: nouveau.vger.kernel.org T24gVHVlc2RheSAzMCBBdWd1c3QgMjAxNiwgQmFveW91IFhpZSB3cm90ZToKPiBPbiAzMCBBdWd1 c3QgMjAxNiBhdCAwMDowMSwgU2VhbiBQYXVsIDxzZWFucGF1bEBnb29nbGUuY29tPiB3cm90ZToK PiAKPiA+IE9uIE1vbiwgQXVnIDI5LCAyMDE2IGF0IDk6MDIgQU0sIEJhb3lvdSBYaWUgPGJhb3lv dS54aWVAbGluYXJvLm9yZz4gd3JvdGU6Cj4gPiA+IFdlIGdldCAxIHdhcm5pbmcgd2hlbiBidWls ZCBrZXJuZWwgd2l0aCBXPTE6Cj4gPiA+IGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L252a20vZW5n aW5lL2dyL2N0eGdtMTA3LmM6OTM3OjE6IHdhcm5pbmc6IG5vCj4gPiBwcmV2aW91cyBwcm90b3R5 cGUgZm9yICdnbTEwN19ncmN0eF9nZW5lcmF0ZV90cGNpZCcgWy1XbWlzc2luZy1wcm90b3R5cGVz XQo+ID4gPgo+ID4gPiBJbiBmYWN0LCB0aGlzIGZ1bmN0aW9uIGlzIG9ubHkgdXNlZCBpbiB0aGUg ZmlsZSBpbiB3aGljaCBpdCBpcwo+ID4gPiBkZWNsYXJlZCBhbmQgZG9uJ3QgbmVlZCBhIGRlY2xh cmF0aW9uLCBidXQgY2FuIGJlIG1hZGUgc3RhdGljLgo+ID4gPiBzbyB0aGlzIHBhdGNoIG1hcmtz IHRoaXMgZnVuY3Rpb24gd2l0aCAnc3RhdGljJy4KPiA+ID4KPiA+Cj4gPiBJdCB3b3VsZCBtYWtl IHRoaW5ncyBhIGxvdCBlYXNpZXIgaWYgeW91IGVpdGhlciBjb25zb2xpZGF0ZWQgYWxsIG9mCj4g PiB0aGVzZSBzdGF0aWMgY2hhbmdlcyBpbnRvIG9uZSBwYXRjaCwgb3IgcmVsZWFzZWQgdGhlbSBh cyBhIHNlcmllcy4KPiA+Cj4gPgo+IERvIHlvdSBtZWFuIHRoYXQgSSBuZWVkIHRvIGNvbnNvbGlk YXRlIGFsbCBvZiB0aGVtIGludG8gb25lIHBhdGNoIHRoaXMKPiB0aW1lPyBvciBuZXh0IHRpbWU/ CgpJJ2Qgc3VnZ2VzdCBjb25zb2xpZGF0aW5nIHRoZSAnbm91dmVhdScgY2hhbmdlcyBpbnRvIGEg c2luZ2xlIHBhdGNoLAphcyB0aGlzIGlzIG9uZSAodmVyeSBiaWcpIGRyaXZlciBhbmQgcmVzZW5k IHRoYXQgb25lLgoKCUFybmQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758574AbcH3MlP (ORCPT ); Tue, 30 Aug 2016 08:41:15 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:53533 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758357AbcH3MlM (ORCPT ); Tue, 30 Aug 2016 08:41:12 -0400 From: Arnd Bergmann To: Baoyou Xie Subject: Re: [PATCH v2] drm/nouveau/gr: mark gm107_grctx_generate_tpcid() static Date: Tue, 30 Aug 2016 14:40:52 +0200 User-Agent: KMail/1.12.2 (Linux/4.7.0-rc7+; KDE/4.3.2; x86_64; ; ) Cc: Sean Paul , bskeggs@redhat.com, Dave Airlie , "dri-devel" , nouveau@lists.freedesktop.org, Linux Kernel Mailing List , xie.baoyou@zte.com.cn References: <1472475747-30296-1-git-send-email-baoyou.xie@linaro.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201608301440.52481.arnd@arndb.de> X-Provags-ID: V03:K0:FIW+qPwu7WspcfegxJErfTIg7friH4CgApGPgZ617a2Zq54kjnn I5XXrsVhOLpQx/Sb9L3qOwMRcJGO3OrYt7beJiMHLg7/gSeaXLFEluGFwP6bWcwt12S0CHD clSO1O0HimZdzon6/wHJBodXAkyKWs2CM5I0lMqCY69uOoR7yaIc//rw0svdw6Hp1soQf3/ Pnuf4WYNAfXfXdDaSgCFQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:2BZgV+v/4Gs=:0hbLBIIwIfzgNpYcvNhdB7 UZ7XaVAOHqsevvdlkKcoWmpyBg1jEzrfy85634HrV8w+ByI48vBujC2AKlBLkcjLf33N2be5P SRRUIDlsJGjBvdv14U0TnC6v5F7dA2qPIoOJEJ3JVCzB3ERpFp4P/yvULOLdUObrN4SSxuIQ0 q81vPKvDl5GSTZPa0r7yNFG2K/s6qRT59//arMNmjZXIRP7W77dXc0VAf/qYYPA+XdaoJTi7M ZhaEBTuLXXyD4XQhc+Qsxb0zYgMk12ziBM1IKBTr2Sh+hzjTxpHtJrd1K+p3BnyMqU1B7yBAE C2YuQushlZTKVlFvwUVMYT95hqQgJl8wYMYPZnyUS+1qNzqRX67iUDnMd7U2h36ZJ1spBEw6F AKYF7cN+xPafb20tI51tSbnk2psQsfBpDpPdNrzQCdZlmRfWpMEXtcbCRtDLYVt8u5ZlFATwJ 0P8NYQ3is5qrBYR4Av0p9nuNuhHbK/VjMVoU65yAxa2O61OTVjPftw2ijO74wP304cVQLRVsQ EJABD//pcG2qEmk8ev9DVbKdDhQ48v4FuR2Uyq6+5N7PKm6WwnjAyCmI1SvERBrDueF1DigaZ 8H+jQy3LXp8LCdRSfFFwrZdHG8W1jtMSyPF4Y+Q5sJ3zqJ6tlPfM1RmRoDhq5ka3pM/1NOJ7l fwugl8yclbrAd1ruAekan1kGG60LfYaYmU1s3MHOLCPmERjlfkQMRIAJwkONClxIoD4wmufrK jM088E6fNdtKd8KA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 30 August 2016, Baoyou Xie wrote: > On 30 August 2016 at 00:01, Sean Paul wrote: > > > On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie wrote: > > > We get 1 warning when build kernel with W=1: > > > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no > > previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes] > > > > > > In fact, this function is only used in the file in which it is > > > declared and don't need a declaration, but can be made static. > > > so this patch marks this function with 'static'. > > > > > > > It would make things a lot easier if you either consolidated all of > > these static changes into one patch, or released them as a series. > > > > > Do you mean that I need to consolidate all of them into one patch this > time? or next time? I'd suggest consolidating the 'nouveau' changes into a single patch, as this is one (very big) driver and resend that one. Arnd