All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Vincent Palatin <vpalatin@chromium.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	Oliver Neukum <oneukum@suse.com>,
	Felipe Balbi <felipe.balbi@linux.intel.com>,
	Bin Gao <bin.gao@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCHv6 1/3] usb: USB Type-C connector class
Date: Tue, 30 Aug 2016 10:00:35 -0700	[thread overview]
Message-ID: <20160830170035.GA29255@roeck-us.net> (raw)
In-Reply-To: <20160830082227.GB10151@kuha.fi.intel.com>

Heikki,

On Tue, Aug 30, 2016 at 11:22:27AM +0300, Heikki Krogerus wrote:
> 
> How about if I add the "supports_usb_power_delivery" attribute for the
> partners instead to give some details about them. Any objections?
> 
After looking into the code again, I assume the idea is to have the existing
supports_usb_power_delivery attribute report if the local port supports the
PD, and to have the partner attribute report if the partner supports the PD
protocol. In other words, it would report the value of usb_pd in struct
typec_partner.

If so, I am ok with it. You might actually consider adding the same attribute
to the cable attributes as well.

Thanks,
Guenter

  parent reply	other threads:[~2016-08-30 17:00 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-22 12:05 [PATCHv6 0/3] USB Type-C Connector class Heikki Krogerus
2016-08-22 12:05 ` [PATCHv6 1/3] usb: USB Type-C connector class Heikki Krogerus
2016-08-24 14:08   ` Vincent Palatin
2016-08-25 11:59     ` Heikki Krogerus
2016-08-26 13:16       ` Vincent Palatin
2016-08-26 14:07         ` Heikki Krogerus
2016-08-29 13:04           ` Guenter Roeck
2016-08-29 13:43             ` Heikki Krogerus
2016-08-29 14:07               ` Heikki Krogerus
2016-08-29 18:50                 ` Guenter Roeck
2016-08-30  8:22                   ` Heikki Krogerus
2016-08-30 15:28                     ` Guenter Roeck
2016-08-30 17:00                     ` Guenter Roeck [this message]
2016-08-22 12:05 ` [PATCHv6 2/3] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Heikki Krogerus
2016-08-22 12:06 ` [PATCHv6 3/3] mfd: intel_soc_pmic_bxtwc: add support for USB Type-C PHY on WhiskeyCove Heikki Krogerus
  -- strict thread matches above, loose matches on Subject: below --
2016-08-29 12:36 [PATCHv6 0/3] USB Type-C Connector class Heikki Krogerus
2016-08-29 12:36 ` [PATCHv6 1/3] usb: USB Type-C connector class Heikki Krogerus
2016-08-29 13:06   ` Vincent Palatin
2016-08-30  9:32   ` Oliver Neukum
2016-08-30 10:04     ` Heikki Krogerus
2016-08-30 11:16       ` Oliver Neukum
2016-08-30 11:49         ` Heikki Krogerus
2016-08-30 13:11           ` Heikki Krogerus
2016-08-30 13:47             ` Guenter Roeck
2016-08-31 11:09               ` Heikki Krogerus
2016-08-31 13:18                 ` Guenter Roeck
2016-08-30 13:46       ` Guenter Roeck
2016-08-30 14:13         ` Heikki Krogerus
2016-08-30 15:40       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160830170035.GA29255@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=bin.gao@linux.intel.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=vpalatin@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.