From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Tue, 30 Aug 2016 18:27:10 +0100 Subject: [PATCH] drivers/perf: arm-pmu: Fix handling of SPI lacking "interrupt-affinity" property In-Reply-To: References: <1468939142-23693-1-git-send-email-marc.zyngier@arm.com> Message-ID: <20160830172710.GJ24906@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Kevin, Thanks for reporting this. On Fri, Aug 26, 2016 at 12:11:55PM -0500, Kevin Hilman wrote: > On Tue, Jul 19, 2016 at 9:39 AM, Marc Zyngier wrote: > > Patch 19a469a58720 ("drivers/perf: arm-pmu: Handle per-interrupt > > affinity mask") added support for partitionned PPI setups, but > > inadvertently broke setups using SPIs without the "interrupt-affinity" > > property (which is the case for UP platforms). > > > > This patch restore the broken functionnality by testing whether the > > interrupt is percpu or not instead of relying on the using_spi flag > > that really means "SPI *and* interrupt-affinity property". > > > > Reported-by: Geert Uytterhoeven > > Tested-by: Geert Uytterhoeven > > Fixes: 19a469a58720 ("drivers/perf: arm-pmu: Handle per-interrupt affinity mask") > > Signed-off-by: Marc Zyngier > > kernelci.org detected boot failures on bcm2835-rpi-b in mainline[1] > and was bisected down to this patch. I verified that reverting this > patch on top of mainline gets bcm2835-rpi-b booting again. > > I haven't been closely tracking this change, but a quick glance and it > looks like this platform is possibly missing IRQ properties from its > PMU node? The DT for this platform simply has: > > arm-pmu { > compatible = "arm,arm1176-pmu"; > }; Stefan Wahren posted a fix for this, so I've queued it locally and plan to send via Catalin: http://lists.infradead.org/pipermail/linux-arm-kernel/2016-August/452475.html Will