From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hellerda-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
ltcgcw-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
gcwilson-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
Subject: Re: Documentation: tpm: Adds the TPM device tree node documentation
Date: Tue, 30 Aug 2016 22:51:56 +0200 [thread overview]
Message-ID: <20160830205156.GA31948@katana> (raw)
In-Reply-To: <1472532277-21933-1-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
On Tue, Aug 30, 2016 at 12:44:37AM -0400, Nayna Jain wrote:
> This is documenting device tree binding for
> I2C based TPM, similar concept which being used
> for virtual TPM on POWER7 and POWER8 systems running PowerVM.
>
> Signed-off-by: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> ---
> Documentation/devicetree/bindings/i2c/i2c-tpm.txt | 29 +++++++++++++++++++++++
Is the driver in 'drivers/i2c/*'? No, so the binding shouldn't be in i2c
as well.
> +- compatible : 'manufacturer,model'
You need to specify them here!
> +Optional properties:
> +
> +- status: indicates whether the device is enabled or disabled. "okay" for
> + enabled and "disabled" for disabled.
Optional? Rather "implicit" I'd say.
This is far from ready. You should really wait for Rob's review. Or
better: Have a look at other bindings.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-30 20:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 4:44 [PATCH] Documentation: tpm: Adds the TPM device tree node documentation Nayna Jain
[not found] ` <1472532277-21933-1-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-08-30 6:36 ` Jarkko Sakkinen
[not found] ` <20160830063631.GA5336-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-30 6:41 ` Peter Huewe
[not found] ` <D8028209-446C-4C50-9AEC-25F6F8C98995-Mmb7MZpHnFY@public.gmane.org>
2016-08-30 6:46 ` Peter Huewe
2016-08-30 7:06 ` [tpmdd-devel] " Jarkko Sakkinen
[not found] ` <20160830070649.GA6215-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-30 8:55 ` Peter Huewe
2016-09-02 14:52 ` Rob Herring
2016-09-02 16:00 ` [tpmdd-devel] " Jarkko Sakkinen
2016-08-30 20:51 ` Wolfram Sang [this message]
2016-09-02 14:51 ` Rob Herring
2016-09-02 17:06 ` Jason Gunthorpe
2016-09-02 17:57 ` [tpmdd-devel] " Rob Herring
[not found] ` <CAL_Jsq+jmAHSGTJPxWZgc_87NTA8uvWZSegx9E7krXKzDcgBmw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-28 8:40 ` Nayna
[not found] ` <20160902170613.GA5024-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-28 8:44 ` Nayna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830205156.GA31948@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gcwilson-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=hellerda-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ltcgcw-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.