From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
bridge@lists.linux-foundation.org, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next v2 2/2] net: bridge: add per-port multicast flood flag
Date: Wed, 31 Aug 2016 03:37:26 +0200 [thread overview]
Message-ID: <20160831013726.GD4883@otheros> (raw)
In-Reply-To: <1472570588-32503-3-git-send-email-nikolay@cumulusnetworks.com>
On Tue, Aug 30, 2016 at 05:23:08PM +0200, Nikolay Aleksandrov via Bridge wrote:
> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
> index 1da3221845f1..ed0dd3340084 100644
> --- a/net/bridge/br_if.c
> +++ b/net/bridge/br_if.c
> @@ -362,7 +362,7 @@ static struct net_bridge_port *new_nbp(struct net_bridge *br,
> p->path_cost = port_cost(dev);
> p->priority = 0x8000 >> BR_PORT_BITS;
> p->port_no = index;
> - p->flags = BR_LEARNING | BR_FLOOD;
> + p->flags = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD;
I'm discontent with this new flag becoming the default.
Could you elaborate a little more on your use-case, when/why do
you want/need this flag?
next prev parent reply other threads:[~2016-08-31 1:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 15:23 [Bridge] [PATCH net-next v2 0/2] net: bridge: add per-port unknown multicast flood control Nikolay Aleksandrov
2016-08-30 15:23 ` Nikolay Aleksandrov via Bridge
2016-08-30 15:23 ` [Bridge] [PATCH net-next v2 1/2] net: bridge: change unicast boolean to exact Nikolay Aleksandrov
2016-08-30 15:23 ` Nikolay Aleksandrov
2016-08-30 15:23 ` [Bridge] [PATCH net-next v2 2/2] net: bridge: add per-port multicast flood flag Nikolay Aleksandrov
2016-08-30 15:23 ` Nikolay Aleksandrov via Bridge
2016-08-31 1:37 ` Linus Lüssing [this message]
2016-08-31 6:02 ` [Bridge] " Nikolay Aleksandrov
2016-08-31 6:02 ` Nikolay Aleksandrov via Bridge
2016-08-31 6:14 ` [Bridge] " Nikolay Aleksandrov
2016-08-31 6:14 ` Nikolay Aleksandrov via Bridge
2016-08-31 17:28 ` [Bridge] " Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831013726.GD4883@otheros \
--to=linus.luessing@c0d3.blue \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.