From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In. Date: Wed, 31 Aug 2016 09:49:59 +0200 Message-ID: <20160831094959.2e5e6ae7@scratchpost.org> References: <20160830054403.7878-1-dannym@scratchpost.org> <20160830054403.7878-3-dannym@scratchpost.org> <20160831094044.1c3227d6@scratchpost.org> Reply-To: dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Maxime Ripard , Mark Brown , linux-kernel , linux-arm-kernel , Linux-ALSA , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , linux-sunxi List-Id: alsa-devel@alsa-project.org Hi Chen-Yu, > My apologies. I didn't notice that VMIC was already in the driver. > In that your original patch did everything right. Don't worry about it :) But I have a question: If I replace DAPM_INPUT by DAPM_MIC it wants a callback that is supposed to fiddle with the bias. Do I provide one? If so, will it conflict with the supply? Or do I leave it as DAPM_INPUT ? From mboxrd@z Thu Jan 1 00:00:00 1970 From: dannym@scratchpost.org (Danny Milosavljevic) Date: Wed, 31 Aug 2016 09:49:59 +0200 Subject: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In. In-Reply-To: References: <20160830054403.7878-1-dannym@scratchpost.org> <20160830054403.7878-3-dannym@scratchpost.org> <20160831094044.1c3227d6@scratchpost.org> Message-ID: <20160831094959.2e5e6ae7@scratchpost.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Chen-Yu, > My apologies. I didn't notice that VMIC was already in the driver. > In that your original patch did everything right. Don't worry about it :) But I have a question: If I replace DAPM_INPUT by DAPM_MIC it wants a callback that is supposed to fiddle with the bias. Do I provide one? If so, will it conflict with the supply? Or do I leave it as DAPM_INPUT ? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933442AbcHaHuV (ORCPT ); Wed, 31 Aug 2016 03:50:21 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:49298 "EHLO dd1012.kasserver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758924AbcHaHuS (ORCPT ); Wed, 31 Aug 2016 03:50:18 -0400 Date: Wed, 31 Aug 2016 09:49:59 +0200 From: Danny Milosavljevic To: Chen-Yu Tsai Cc: Maxime Ripard , Mark Brown , linux-kernel , linux-arm-kernel , Linux-ALSA , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , linux-sunxi Subject: Re: [linux-sunxi] Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In. Message-ID: <20160831094959.2e5e6ae7@scratchpost.org> In-Reply-To: References: <20160830054403.7878-1-dannym@scratchpost.org> <20160830054403.7878-3-dannym@scratchpost.org> <20160831094044.1c3227d6@scratchpost.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chen-Yu, > My apologies. I didn't notice that VMIC was already in the driver. > In that your original patch did everything right. Don't worry about it :) But I have a question: If I replace DAPM_INPUT by DAPM_MIC it wants a callback that is supposed to fiddle with the bias. Do I provide one? If so, will it conflict with the supply? Or do I leave it as DAPM_INPUT ?