All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Amir Levy <amir.jer.levy@intel.com>
Cc: andreas.noever@gmail.com, bhelgaas@google.com, corbet@lwn.net,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	netdev@vger.kernel.org, linux-doc@vger.kernel.org,
	thunderbolt-linux@intel.com, mika.westerberg@intel.com,
	tomas.winkler@intel.com
Subject: Re: [PATCH v6 5/8] thunderbolt: Networking state machine
Date: Wed, 31 Aug 2016 13:35:23 +0200	[thread overview]
Message-ID: <20160831113523.GF17607@kroah.com> (raw)
In-Reply-To: <1470054233-4309-6-git-send-email-amir.jer.levy@intel.com>

On Mon, Aug 01, 2016 at 03:23:50PM +0300, Amir Levy wrote:
> Negotiation states that a peer goes through in order to establish
> the communication with the second peer.

I can not parse that sentance, what exactly does that mean?

> This includes communication with upper layer and additional
> infrastructure support to communicate with the second peer through ICM.

This too is unparsable.  Please explain what this patch does in terms
that are understandable for someone with at least a passing
understanding of hardware busses.  As it is, I have no idea what this
patch does at all, and I should be your target audience for this
changelog.

thanks,

greg k-h

  reply	other threads:[~2016-08-31 11:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01 12:23 [PATCH v6 0/8] thunderbolt: Introducing Thunderbolt(TM) networking Amir Levy
2016-08-01 12:23 ` [PATCH v6 1/8] thunderbolt: Macro rename Amir Levy
2016-09-10 23:20   ` Andreas Noever
2016-08-01 12:23 ` [PATCH v6 2/8] thunderbolt: Updating the register definitions Amir Levy
2016-09-11  0:02   ` Andreas Noever
2016-09-11 13:19     ` Levy, Amir (Jer)
2016-09-11 13:19       ` Levy, Amir (Jer)
2016-08-01 12:23 ` [PATCH v6 3/8] thunderbolt: Kconfig for Thunderbolt(TM) networking Amir Levy
2016-08-31 11:29   ` Greg KH
2016-08-31 11:30   ` Greg KH
2016-08-01 12:23 ` [PATCH v6 4/8] thunderbolt: Communication with the ICM (firmware) Amir Levy
2016-08-31 11:34   ` Greg KH
2016-08-01 12:23 ` [PATCH v6 5/8] thunderbolt: Networking state machine Amir Levy
2016-08-31 11:35   ` Greg KH [this message]
2016-08-01 12:23 ` [PATCH v6 6/8] thunderbolt: Networking transmit and receive Amir Levy
2016-08-01 12:23 ` [PATCH v6 7/8] thunderbolt: Networking doc Amir Levy
2016-08-31 11:39   ` Greg KH
2016-08-01 12:23 ` [PATCH v6 8/8] thunderbolt: Adding maintainer entry Amir Levy
2016-08-31 11:28 ` [PATCH v6 0/8] thunderbolt: Introducing Thunderbolt(TM) networking Greg KH
2016-09-10 23:19   ` Andreas Noever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160831113523.GF17607@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=amir.jer.levy@intel.com \
    --cc=andreas.noever@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mika.westerberg@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=thunderbolt-linux@intel.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.