diff for duplicates of <20160831114403.GB8649@dell> diff --git a/a/1.txt b/N1/1.txt index b57d165..4c148c3 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -113,7 +113,7 @@ Are you still reviewing Backlight patches? > +module_param_named(iledstr, s_iledstr, int, 0644); > +MODULE_PARM_DESC(iledstr, "Initial LED String (when no plat data)"); > + -> +static int s_retries = 2; /* 1 = only one try */ +> +static int s_retries = 2; /* 1 == only one try */ > +module_param_named(retries, s_retries, int, 0644); > +MODULE_PARM_DESC(retries, "I2C retries attempted"); > + @@ -229,17 +229,17 @@ Are you still reviewing Backlight patches? > + brightness = 0; > + > + /* set brightness */ -> + if (lp->mode = PWM_BASED) +> + if (lp->mode == PWM_BASED) > + arcxcnn_pwm_ctrl(lp, brightness, bl->props.max_brightness); -> + else if (lp->mode = REGISTER_BASED) +> + else if (lp->mode == REGISTER_BASED) > + arcxcnn_set_brightness(lp, brightness); > + > + /* set power-on/off/save modes */ -> + if (bl->props.power = 0) +> + if (bl->props.power == 0) > + /* take out of standby */ > + arcxcnn_update_bit(lp, ARCXCNN_CMD, ARCXCNN_CMD_STDBY, 0); > + else -> + /* 1-3 = power save, 4 = off +> + /* 1-3 == power save, 4 = off > + * place in low-power standby mode > + */ > + arcxcnn_update_bit(lp, ARCXCNN_CMD, @@ -305,7 +305,7 @@ Are you still reviewing Backlight patches? > + > + if (ledstr != lp->pdata->ledstr) { > + /* don't allow 0 for ledstr, use power to turn all off */ -> + if (ledstr = 0) +> + if (ledstr == 0) > + return 0; > + lp->pdata->ledstr = ledstr & 0x3F; > + arcxcnn_update_bit(lp, ARCXCNN_LEDEN, @@ -320,9 +320,9 @@ Are you still reviewing Backlight patches? > + struct arcxcnn *lp = dev_get_drvdata(dev); > + char *strmode = NULL; > + -> + if (lp->mode = PWM_BASED) +> + if (lp->mode == PWM_BASED) > + strmode = "pwm based"; -> + else if (lp->mode = REGISTER_BASED) +> + else if (lp->mode == REGISTER_BASED) > + strmode = "register based"; > + > + return scnprintf(buf, PAGE_SIZE, "%s\n", strmode); @@ -611,5 +611,5 @@ Are you still reviewing Backlight patches? -- Lee Jones Linaro STMicroelectronics Landing Team Lead -Linaro.org │ Open source software for ARM SoCs +Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog diff --git a/a/content_digest b/N1/content_digest index 8c1166d..617e09a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01471893103-4593-1-git-send-email-olimpiu@arcticsand.com\0" "From\0Lee Jones <lee.jones@linaro.org>\0" "Subject\0Re: [PATCH] backlight: arcxcc: add support for ArcticSand devices\0" - "Date\0Wed, 31 Aug 2016 11:44:03 +0000\0" + "Date\0Wed, 31 Aug 2016 12:44:03 +0100\0" "To\0Olimpiu Dejeu <olimpiu@arcticsand.com>\0" "Cc\0linux-kernel@vger.kernel.org" linux-fbdev@vger.kernel.org @@ -124,7 +124,7 @@ "> +module_param_named(iledstr, s_iledstr, int, 0644);\n" "> +MODULE_PARM_DESC(iledstr, \"Initial LED String (when no plat data)\");\n" "> +\n" - "> +static int s_retries = 2; /* 1 = only one try */\n" + "> +static int s_retries = 2; /* 1 == only one try */\n" "> +module_param_named(retries, s_retries, int, 0644);\n" "> +MODULE_PARM_DESC(retries, \"I2C retries attempted\");\n" "> +\n" @@ -240,17 +240,17 @@ "> +\t\tbrightness = 0;\n" "> +\n" "> +\t/* set brightness */\n" - "> +\tif (lp->mode = PWM_BASED)\n" + "> +\tif (lp->mode == PWM_BASED)\n" "> +\t\tarcxcnn_pwm_ctrl(lp, brightness, bl->props.max_brightness);\n" - "> +\telse if (lp->mode = REGISTER_BASED)\n" + "> +\telse if (lp->mode == REGISTER_BASED)\n" "> +\t\tarcxcnn_set_brightness(lp, brightness);\n" "> +\n" "> +\t/* set power-on/off/save modes */\n" - "> +\tif (bl->props.power = 0)\n" + "> +\tif (bl->props.power == 0)\n" "> +\t\t/* take out of standby */\n" "> +\t\tarcxcnn_update_bit(lp, ARCXCNN_CMD, ARCXCNN_CMD_STDBY, 0);\n" "> +\telse\n" - "> +\t\t/* 1-3 = power save, 4 = off\n" + "> +\t\t/* 1-3 == power save, 4 = off\n" "> +\t\t * place in low-power standby mode\n" "> +\t\t */\n" "> +\t\tarcxcnn_update_bit(lp, ARCXCNN_CMD,\n" @@ -316,7 +316,7 @@ "> +\n" "> +\tif (ledstr != lp->pdata->ledstr) {\n" "> +\t\t/* don't allow 0 for ledstr, use power to turn all off */\n" - "> +\t\tif (ledstr = 0)\n" + "> +\t\tif (ledstr == 0)\n" "> +\t\t\treturn 0;\n" "> +\t\tlp->pdata->ledstr = ledstr & 0x3F;\n" "> +\t\tarcxcnn_update_bit(lp, ARCXCNN_LEDEN,\n" @@ -331,9 +331,9 @@ "> +\tstruct arcxcnn *lp = dev_get_drvdata(dev);\n" "> +\tchar *strmode = NULL;\n" "> +\n" - "> +\tif (lp->mode = PWM_BASED)\n" + "> +\tif (lp->mode == PWM_BASED)\n" "> +\t\tstrmode = \"pwm based\";\n" - "> +\telse if (lp->mode = REGISTER_BASED)\n" + "> +\telse if (lp->mode == REGISTER_BASED)\n" "> +\t\tstrmode = \"register based\";\n" "> +\n" "> +\treturn scnprintf(buf, PAGE_SIZE, \"%s\\n\", strmode);\n" @@ -622,7 +622,7 @@ "-- \n" "Lee Jones\n" "Linaro STMicroelectronics Landing Team Lead\n" - "Linaro.org \303\242\342\200\235\342\200\232 Open source software for ARM SoCs\n" + "Linaro.org \342\224\202 Open source software for ARM SoCs\n" Follow Linaro: Facebook | Twitter | Blog -7f7f1ffaf1ff4dbff151f51acbd988f16c49bb52b2558835ef7f19e147234af9 +63ff22e0d9a8b3acc82c03669087f24f5c12e2ceacb6267c87470b9e6ab400d9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.