From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934678AbcHaNbO (ORCPT ); Wed, 31 Aug 2016 09:31:14 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:38859 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934598AbcHaNbJ (ORCPT ); Wed, 31 Aug 2016 09:31:09 -0400 Date: Wed, 31 Aug 2016 15:31:04 +0200 From: Peter Zijlstra To: Benjamin Herrenschmidt Cc: Oleg Nesterov , Balbir Singh , LKML , Nicholas Piggin Subject: Re: [RFC][PATCH] Fix a race between rwsem and the scheduler Message-ID: <20160831133104.GD10153@twins.programming.kicks-ass.net> References: <4050f2ce-1aee-d2aa-39e3-36e995b56252@gmail.com> <20160830121937.GQ10138@twins.programming.kicks-ass.net> <20160830130426.GA17795@redhat.com> <20160830141321.GB2794@worktop> <20160830165746.GA29218@redhat.com> <20160830183416.GV10138@twins.programming.kicks-ass.net> <1472592498.2388.40.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472592498.2388.40.camel@kernel.crashing.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2016 at 07:28:18AM +1000, Benjamin Herrenschmidt wrote: > On powerpc we have a sync deep in _switch to achieve that. OK, for giggles, could you (or Balbir) check what happens if you take that sync out? There should be enough serialization in the generic code to cover the case that code mentions. ARM64 has a stronger barrier in its context switch code, but that's because they need to sync against external agents (like their TLB and cache) and no amount of generic locking is going to cover that.