From: Mike Snitzer <snitzer@redhat.com>
To: Milan Broz <gmazyland@gmail.com>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
Ming Lei <tom.leiming@gmail.com>, Jens Axboe <axboe@kernel.dk>,
Eric Wheeler <dm-devel@lists.ewheeler.net>,
Christoph Hellwig <hch@lst.de>,
johnstonj.public@codenest.com,
linux-block <linux-block@vger.kernel.org>
Subject: Re: dm-crypt: Fix error with too large bios
Date: Wed, 31 Aug 2016 09:39:09 -0400 [thread overview]
Message-ID: <20160831133908.GA1001@redhat.com> (raw)
In-Reply-To: <6a58fece-c60b-9dc2-e2e6-bee4e877a376@gmail.com>
On Wed, Aug 31 2016 at 2:26am -0400,
Milan Broz <gmazyland@gmail.com> wrote:
> On 08/31/2016 12:27 AM, Mikulas Patocka wrote:
>
> ...
> >
> > Drop that "#ifdef CONFIG_BCACHE". Anyone should be allowed to create a big
> > bio, not just bcache.
>
> Yes. Please, do not hide it behind #ifdef.
> If it is in code, it should be enabled always.
>
> There can third party modules or some new code appears and creating strange
> config dependence only adds more problems later.
I did last night, see:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.8&id=4e870e948fbabf62b78e8410f04c67703e7c816b
Will go to Linus for v4.8-rc5 by the end of the week.
next prev parent reply other threads:[~2016-08-31 13:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 3:56 [PATCH] Re: dm-crypt: Fix error with too large bios Eric Wheeler
2016-08-13 17:45 ` Mikulas Patocka
2016-08-14 0:07 ` Mike Snitzer
2016-08-15 17:03 ` Mikulas Patocka
2016-08-19 0:47 ` Eric Wheeler
2016-08-25 18:34 ` Mikulas Patocka
2016-08-25 18:34 ` [dm-devel] " Mikulas Patocka
2016-08-25 20:13 ` Jens Axboe
2016-08-26 14:05 ` Mike Snitzer
2016-08-27 15:09 ` Mikulas Patocka
2016-08-29 5:22 ` Ming Lei
2016-08-29 21:57 ` Mikulas Patocka
2016-08-30 7:33 ` Ming Lei
2016-08-30 12:19 ` Mikulas Patocka
2016-08-30 20:57 ` Mike Snitzer
2016-08-30 22:27 ` Mikulas Patocka
2016-08-31 6:26 ` Milan Broz
2016-08-31 13:39 ` Mike Snitzer [this message]
2016-08-29 18:19 ` Mike Snitzer
2016-08-29 22:01 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831133908.GA1001@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.ewheeler.net \
--cc=gmazyland@gmail.com \
--cc=hch@lst.de \
--cc=johnstonj.public@codenest.com \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.